Repository navigation
fix: tell the user when Rancher Desktop is not installed or not running (1.8.3) - #103
Merged
Merged
Conversation
…ng (1.8.3) Found on Terje's Windows PC (urb-agents #1536): with Rancher Desktop not running, install.ps1 wrote its files, `docker pull` failed, and it still printed "devcontainer-toolbox installed!". install.ps1: - Step 1 now checks, before anything is written, whether Rancher Desktop is installed (user and system install paths), visible to this window (`docker` on PATH), and running (`docker info`), with a plain message for each case that says what to do next. - A failed `docker pull` stops without claiming success. - The body runs in a script block and uses `return` instead of `exit`, so a stop under `irm | iex` no longer closes the user's window or leaks ErrorActionPreference into their session. install.sh: the same plain messages, naming Rancher Desktop (not Docker Desktop, which needs a paid licence for companies). Tested with stub `docker` commands in PowerShell (via Invoke-Expression, like the Quick Start) and bash. Not yet run on Windows. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on Terje's Windows PC (urb-agents #1536). Rancher Desktop wasn't running.
install.ps1wrote its files,docker pullfailed withfailed to connect to the docker API at npipe:////./pipe/docker_engine, and it still printed "devcontainer-toolbox installed!".Changes
install.ps1, step 1, runs before anything is written. It checks three things, each with a plain message and the next action:docker pullstops without claiming success.returninstead ofexit. Underirm | iex, a stop no longer closes the user's window or leaksErrorActionPreferenceinto their session. (PLAN-fix-windows-quickstart task 2.1)install.sh: the same plain messages, and it names Rancher Desktop instead of Docker Desktop.C:\Windows\System32, where an administrator PowerShell opens.Verification
Get-Content install.ps1 -Raw | Invoke-Expression(as the Quick Start runs it), with stubdocker:ErrorActionPreferenceis unchanged.dockernot on PATH: the "installed, but this terminal can't see it" message.install.ps1: 0 parse errors, 0 PSScriptAnalyzer findings apart fromPSAvoidUsingWriteHost.install.sh: shellcheck-clean.npm run buildpasses.🤖 Generated with Claude Code