Repository navigation
fix(dct-init): find docker in Rancher Desktop's own folder when PATH is stale - #106
Merged
Merged
Conversation
…is stale client-provisioning's installer installs Rancher Desktop and calls dct-init in one process, so PATH does not yet contain Rancher's bin folder and dct-init would wrongly report ERR002 (urb-agents #1543). dct-init now looks on PATH first, then where Rancher puts docker, and uses that full path: - Windows: <install>\resources\resources\win32\bin\docker.exe (per-user and machine installs; the path client-provisioning's tested scripts use) - Mac: ~/.rd/bin/docker (measured), then the app bundle; Linux: /opt/rancher-desktop CI: a stale-PATH case on windows-latest (a stub docker.exe compiled with Add-Type in Rancher's bin folder) and on Linux (~/.rd/bin). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ask 3.2) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From client-provisioning's question on urb-agents #1543. Their installer installs Rancher Desktop and then calls
dct-initin one process, so PATH is stale, anddct-initwould wrongly sayERR002(Rancher installed but not visible).dct-initnow looks on PATH first, then where Rancher putsdocker, and uses that full path fordocker info/docker pull.<install>\resources\resources\win32\bin\docker.exeunder%LOCALAPPDATA%\Programs\Rancher Desktopand%ProgramFiles%\Rancher Desktoppaths.ts)~/.rd/bin/docker, then the app bundle~/.rd/binmeasured on a Mac; the bundle path is inferred from the source/opt/rancher-desktop/resources/resources/linux/bin/dockerTests: a new stale-PATH case in CI.
docker.exe, compiled withAdd-Type, sits in Rancher's bin folder, with no docker on PATH.~/.rd/bin.🤖 Generated with Claude Code