Repository navigation
Regenerate Graphite theme after edge history selector change - #1603
Merged
Merged
Conversation
Owner
|
@DevxDre thank you, this is exactly the stale Graphite stylesheet that made the unit test fail on main. The two selectors match |
Owner
|
@DevxDre released with layerling 1.156.4. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit
7ee177c75narrowed the edge history note selector inglobals.cssto direct child spans. The generated Graphite stylesheet still used the descendant selector, so the Graphite freshness test failed.This regenerates the stylesheet with
npm run theme:graphite. The two changed selectors now matchglobals.css. Storage, import, export, grouping and undo/redo behavior are unchanged.Verification
npm test -- tests/unit/graphiteTheme.test.ts(4 passed)npm run ci(typecheck passed, 5,500 unit tests passed, 7 skipped)git diff --check