[AARCH-25890] Ordering semantics of the address translation of tag checked instructions - #1932
Open
relokin wants to merge 6 commits into
Open
[AARCH-25890] Ordering semantics of the address translation of tag checked instructions#1932relokin wants to merge 6 commits into
relokin wants to merge 6 commits into
Conversation
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
relokin
changed the title
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
Signed-off-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
TiberiuBucur
reviewed
Sep 3, 2026
TiberiuBucur
left a comment
TiberiuBucur
left a comment
Collaborator
There was a problem hiding this comment.
A few small non-blocking comments. Happy to approve once we fix the merge conflicts.
Comment on lines
+1488
to
+1489
| match is_mte_sync dir with | ||
| | true -> |
Collaborator
There was a problem hiding this comment.
Could we maybe use an if statement instead of a match on booleans?
| fun ma -> | ||
| let set_tfsr = write_reg AArch64Base.tfsr V.one ii in | ||
| let ma = ma >>*== (fun a -> (set_tfsr >>| mfault) >>! a) in | ||
| let ma = ma >>**== (fun a -> (set_tfsr >>| mfault) >>! a) in |
Collaborator
There was a problem hiding this comment.
Why do we want the extra data dependencies from the register and tag memory read effects to the TFSR_ELx write effect and to the fault effect?
Comment on lines
+1579
to
+1581
| match is_mte_sync dir with | ||
| | true -> mtag | ||
| | false -> |
Comment on lines
+1635
to
+1637
| match is_mte_sync dir with | ||
| | true -> ma | ||
| | false -> ma >>*== (fun a -> noact >>! a) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.