Aligning implementation/specification error codes - phase 4

[Roman-Manevich]

Classify unsupported parameter expressions

Expressions that cannot define subprogram parameters now report TE_BSPD through BadParameterExpr, matching params_of_expr in asl.spec.

Classify invalid collection field types

Non-bitvector collection fields now report TE_UT through check_structure_bits, matching the per-field check_structure_label checks in asl.spec.

Classify unsupported parameter types

Types not permitted as subprogram argument or return types now report TE_BSPD through BadParameterType; asl.spec and a documented regression now cover pending-constrained integers, and the obsolete UnsupportedTy diagnostic is removed.

Classify out-of-bounds indices

Out-of-bounds native vector accesses now report DE_BI, or TE_SEF during static evaluation, through BadIndex instead of the uncoded MismatchType diagnostic.

Classify arbitrary negative-length arrays

Parameterized arrays whose length evaluates negatively now report DE_AET through ArbitraryEmptyType, matching EArbitrary in asl.spec.

Classify static evaluation failures

Static evaluation that does not produce a literal now reports TE_SEF through StaticEvaluationFailure, matching static_eval in asl.spec.

Classify implementation integer overflow

Integers exceeding OCaml int limits now report a structured internal ImplementationIntegerOverflow diagnostic instead of the uncoded UnsupportedExpr.

[HadrienRenaud]

worth a record I think

[Roman-Manevich]

I prefer records, but why this specific one and not all other constructors with multiple fields?

[HadrienRenaud]

Oh I had forgotten we had this limitation. Could we put it on a ticket please?

[Roman-Manevich]

I'm not sure what you want the ticket to say.