Replace AsSliceU8 trait with zerocopy::AsBytes #692

Activity

1. mkroening

   added

   soundnessSomething is unsound.Something is unsound.

   on Mar 26, 2023
2. joannejchen commented on Mar 27, 2023

   

   joannejchen

   on Mar 27, 2023

   Contributor

   More actions

   Hi @mkroening! @scotran and I are part of a Virtualization course at UT Austin, and as part of a project we have to contribute to open source repositories. Can we take up this issue?
3. mkroening commented on Mar 27, 2023

   

   mkroening

   on Mar 27, 2023

   MemberAuthor

   More actions

   Sure, do you want to do all three issues?

   PS: To assign @scotran, he has to be a participant of this issue. Just write anything, then I can add him as well.

   👍React with 👍1Reacted by Joanne Chen
4. mkroening

   assigned

   joannejchen

   on Mar 27, 2023
5. joannejchen commented on Mar 27, 2023

   

   joannejchen

   on Mar 27, 2023

   Contributor

   More actions

   Yep, all three issues would be great!
6. joannejchen commented on Apr 20, 2023

   

   joannejchen

   on Apr 20, 2023

   Last edited by joannejchen

   Contributor

   More actions

   Hi @mkroening! I was able to switch the VirtioNetHdr (currently reflected in the pull request created) from implementing AsSliceU8 to deriving AsBytes, but I ran into an issue when trying to change from AsSliceU8 to AsBytes for the Cmd and Rsp structs (https://github.com/hermitcore/libhermit-rs/blob/master/src/fs/fuse.rs#L293): #[derive(AsBytes)] is not supported on types with type parameters. Digging around, there seems to be a workaround (google/zerocopy#10), but this would require using repr(transparent), which then cannot be used alongside repr(C) or repr(packed), which would strip padding and possibly cause alignment issue.

   I just wanted to touch base first as to whether this would be the desired approach, and if so, I can continue looking into how to derive AsBytes for structs with type parameters.
7. joannejchen

   added 7 commits that reference this issue on Apr 20, 2023

   Replace AsSliceU8 trait with zerocopy::AsBytes.

   ...

   This issue will close once commit 7f09f38 is merged into the 'master' branch.

   7f09f38

   Replace AsSliceU8 trait with zerocopy::AsBytes.

   ...

   This issue will close once commit f046402 is merged into the 'master' branch.

   f046402

   Replace AsSliceU8 trait with zerocopy::AsBytes.

   ...

   This issue will close once commit 096b8d4 is merged into the 'master' branch.

   096b8d4

   Replace AsSliceU8 trait with zerocopy::AsBytes.

   ...

   This issue will close once commit 5934f22 is merged into the 'master' branch.

   5934f22

   Directly implement AsBytes trait for Generic structs [experiemntal].

   ...

   This issue will close once commit eb56619 is merged into the 'master' branch.

   eb56619

   Directly implement AsBytes trait for Generic structs [experiemntal].

   ...

   This issue will close once commit 2b7bb6c is merged into the 'master' branch.

   2b7bb6c

   Replace AsSliceU8 trait with zerocopy::AsBytes for VirtioNetHdr struct.

   ...

   This issue will close once commit 697de57 is merged into the 'master' branch.

   697de57
8. mkroening

   assigned

   cagatay-y

   and unassigned

   joannejchen

   on Oct 31, 2023
9. mkroening commented on Dec 7, 2023

   

   mkroening

   on Dec 7, 2023

   MemberAuthor

   More actions

   Just as an aside, there is a proposal for DynSized, with a very similar purpose to our AsSliceU8: rust-lang/rfcs#3536
10. cagatay-y commented on Sep 17, 2024

    

    cagatay-y

    on Sep 17, 2024

    Contributor

    More actions

    AsSliceU8 was removed with #1316. I think we can close this issue.

    👍React with 👍1Reacted by Martin Kröning
11. mkroening commented on Sep 17, 2024

    

    mkroening

    on Sep 17, 2024

    MemberAuthor

    More actions

    Superseded by #1316
12. mkroening

    closed this as completedon Sep 17, 2024