feat: enhance dropdown icon triggers with ghost and outline styles - #4
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the HDropdownComponent to support a new 'outline' icon trigger style in addition to the existing 'ghost' style (previously represented by a boolean), adding corresponding CSS classes and updating the Storybook stories. The reviewer pointed out that changing the iconTrigger input type is a breaking change and suggested using an input transform to map true or empty string values to 'ghost' to maintain backwards compatibility.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
ui-kit | 37798b1 | Commit Preview URL Branch Preview URL |
May 29 2026, 10:13 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request enhances the
HDropdownComponentby expanding theiconTriggeroption to support both "ghost" and "outline" visual styles, and updates the component and its stories to demonstrate these new options. The changes improve flexibility for consumers of the dropdown menu and add a new outlined icon trigger style.Component enhancements:
iconTriggerinput inHDropdownComponentto accept'ghost','outline', orfalse, with a custom transform to maintain backward compatibility. (projects/hestia-ui/src/lib/menu/menu.component.tsprojects/hestia-ui/src/lib/menu/menu.component.tsL201-R218)iconTriggervalue, enabling both "ghost" and "outline" trigger styles. (projects/hestia-ui/src/lib/menu/menu.component.tsprojects/hestia-ui/src/lib/menu/menu.component.tsL49-R49)Styling updates:
.h-dropdown-trigger--icon-outlineto provide a distinct outlined button appearance for the dropdown trigger. (projects/hestia-ui/src/lib/menu/menu.component.tsprojects/hestia-ui/src/lib/menu/menu.component.tsR133-R146)Storybook/demo updates:
IconTriggerstory into two:IconTriggerGhostandIconTriggerOutline, each demonstrating one of the new trigger styles. (projects/hestia-ui/src/lib/menu/menu.stories.ts[1] [2]Code cleanup:
booleanAttributeimport from the menu component file. (projects/hestia-ui/src/lib/menu/menu.component.tsprojects/hestia-ui/src/lib/menu/menu.component.tsL6)