feat(sql): bind typed parameters across database clients - #4
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
SQL parameters were newline-delimited bytes. A multiline value became several parameters, and applications could not bind NULL, booleans or binary data reliably.
What
Add
hew.db.sql.Paramwith Null, Bool, Int, Float, Text and Bytes variants. SQLite, MySQL and PostgreSQL acceptVec<Param>, use Hew's wire codec internally and bind native typed values. PostgreSQL prepares typed parameters instead of coercing every input to text. Empty values remain distinct from NULL.Test
make lint.