Conversation
Bare Some, None, Ok and Err in expression position are refused from Hew v0.6.0; the packages use .Ok(x) where the expected type selects the enum and Result.Ok(x) where nothing does.
A block at the start of a statement now ends at its closing brace, so using its value as an operand needs parentheses.
Contributor
Author
|
Absorbed by #6, which moves every package onto the rc4 surface and replaces the close handlers these hunks touched. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Hew refuses bare
Some,None,OkandErrin expression position (hew-lang/hew#3240), and a block at the start of a statement now ends at its closing brace, so the packages stop type-checking on a compiler that carries these rules.What
Each bare constructor becomes the checker's fix-it:
.Ok(x)where the expected type selects the enum,Result.Ok(x)where nothing does. Theunsafeblock compared innatshas_replyis parenthesized.Test
scripts/corpus-gate.sh checkpasses with a compiler carrying the rules;verify_package_contract.pyandverify-pins.shpass.