refactor(sdk): consolidate visual paint heuristics - #3122
Open
leorivastech wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Consolidates the duplicated visual-paint color parsing used by the SDK, Studio, captions, and the CLI browser audit.
box-shadowandaudiopolicy.Fixes #3079.
Why
The existing copies already disagreed. In particular, Studio and captions only recognized a few transparent spellings, so a computed color such as
rgba(255, 255, 255, 0)could be treated as painted. The CLI also maintained a separate alpha parser.Keeping the pure parser in Core lets the SDK expose the shared host API while the CLI can bundle the function into its dependency-free browser payload. Caller-specific policy remains local.
How
cssColorAlphaandisTransparentColorunder@hyperframes/core/visual-paint.@hyperframes/sdk/visual-paintand uses the helper in the iframe adapter.layout-audit.browser.jsat load time with a lexical, serializedcssColorAlpha; the source script remains an internal template and the delivered payload remains standalone.Test plan
Verified: