revert: the video-primitive registry, its previews do not deploy - #3162
Merged
Conversation
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
|
Preview deployment for your docs. Learn more about Mintlify Previews.
💡 Tip: Enable Workflows to automatically generate PRs for you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reverts #3090. Restores the tree to exactly what it was immediately before that merge, leaving #3155 untouched.
Why
Every catalog page's preview is a 404 in production.
#3090 put 42 MB across 1,278 files under
docs/public/catalog, and the docs host publishes none of it. Not one file in that subtree serves, whiledocs/public/imagesat 200 KB serves fine anddocs/public/catalog-index.jsonserves with all 358 items. So the deploy is current,docs/public/**does map to/public/**, and it is specifically the new heavy subtree that never shipped.The pages deployed without their assets. Each of the 358 generated pages embeds
/public/catalog/preview/<kind>/<name>.htmlin an iframe, and every one of those answers 404.The compositions are not reachable anywhere else either:
raw.githubusercontent.comserves them 200, but astext/plain, so an iframe will not render them.How
git revertof the squash commit. Nothing had landed on top, so it is clean, and the tree now matches6de29f5beexactly.What this does not fix
Previews were already broken in production before #3090, in a different way: the pages pointed at
.mp4files on the CDN that answered 403 because nothing uploads them. This revert restores that state. It removes 358 broken pages rather than repairing the underlying problem.The real fix is to stop shipping composition copies inside the docs bundle and serve them from the CDN that
docs/images/already uses, which needs the upload path wired. Failing that, the preview copy has to carry only what a preview needs: 27.4 MB of the 42 MB is binaries over 200 KB, including three copies of the same 2.4 MBmacbook.glb.Test plan
git diff 6de29f5be HEADis empty, so the revert undoes #3090 and nothing else, and #3155's media-use work is untouched. lint, format andtest:scriptsall exit 0.