Skip to content

Handle Ubuntu 24+/26+ Chromium sandbox startup failures in Electron launcher - #1008

Closed
highperformancecoder with Copilot wants to merge 5 commits into
masterfrom
copilot/fix-minsky-hang-issue
Closed

highperformancecoder with Copilot wants to merge 5 commits into
masterfrom
copilot/fix-minsky-hang-issue

Conversation

Copilot AI commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

On Ubuntu 24.04+ (and likely 26.04), Minsky could fail at startup with Chromium sandbox errors unless launched manually with --no-sandbox; in that path, users reported unstable behavior including UI hangs around Resetting: 100%. This change makes startup behavior distro-aware so affected Linux installs launch reliably without requiring manual flags.

  • Linux sandbox compatibility gating

    • Added linux-sandbox.ts to centralize detection of when the Electron process should append --no-sandbox.
    • Detection uses /etc/os-release (ID, ID_LIKE, VERSION_ID) and applies only to Ubuntu-like distros at version >= 24.
    • Added a safety gate: only fall back to --no-sandbox when a usable setuid chrome-sandbox is not present.
  • Electron startup integration

    • Wired App.main(...) to call the new helper and conditionally append:
      if (requiresNoSandboxOnLinux()) {
        app.commandLine.appendSwitch('no-sandbox');
      }
    • Keeps existing startup behavior unchanged on non-Linux platforms and unaffected Linux environments.
  • Regression coverage

    • Added focused tests for:
      • Ubuntu 24.04 / 26.04 detection
      • mixed-case / quoted ID normalization
      • Ubuntu-like detection via ID_LIKE
      • negative cases (Ubuntu 22.04, non-Ubuntu, non-Linux)
      • gating behavior when a usable sandbox exists

This change is Reviewable

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: d3d1943c-eb13-4bb4-96ce-56234a1d04a7

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI and others added 4 commits September 28, 2026 06:05
Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Co-authored-by: highperformancecoder <3075825+highperformancecoder@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix Minsky hangs with Wait... Resetting: 100% Handle Ubuntu 24+/26+ Chromium sandbox startup failures in Electron launcher Sep 28, 2026
@highperformancecoder

Copy link
Copy Markdown
Owner

Addressed elswhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minsky hangs with Wait... Resetting: 100%

2 participants