Skip to content

Forward unknown long-form CLI flags to Electron while preserving app argument semantics #1009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
highperformancecoder merged 5 commits into from
Sep 29, 2026
Merged

Forward unknown long-form CLI flags to Electron while preserving app argument semantics #1009

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
e56ba2c
Forward unknown CLI flags to Electron commandLine
Copilot Sep 28, 2026
c4fd6f3
Preserve -- delimiter when forwarding CLI switches
Copilot Sep 28, 2026
09280c3
Iterate argv values directly in CLI parser
Copilot Sep 28, 2026
25456d8
Forward only double-dash CLI switches
Copilot Sep 28, 2026
8784a64
Parse only user CLI args for startup handling
Copilot Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 35 additions & 10 deletions gui-js/apps/minsky-electron/src/app/app.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ export default class App {
static application: Electron.App;
static BrowserWindow;
static directlyClose = false;
static cliArguments=[]; // first argument passed on command line
static cliArguments=[]; // positional arguments passed on command line

private static onWindowAllClosed() {
App.application.quit();
Expand Down Expand Up @@ -66,12 +66,12 @@ export default class App {
await App.initMenu();
App.loadMainWindow();
backend('minsky.popFlags');
if (App.cliArguments.length>1) {
if (!isAbsolute(App.cliArguments[1]))
App.cliArguments[1]=join(initialWorkingDirectory,App.cliArguments[1]);
if (App.cliArguments.length>0) {
if (!isAbsolute(App.cliArguments[0]))
App.cliArguments[0]=join(initialWorkingDirectory,App.cliArguments[0]);
try
{
await CommandsManager.openNamedFile(App.cliArguments[1]);
await CommandsManager.openNamedFile(App.cliArguments[0]);
BookmarkManager.updateBookmarkList();
}
catch (err) {
Expand Down Expand Up @@ -207,9 +207,17 @@ export default class App {

// when run from npm start, argv[0] is 'electron'
if (process.argv[0].slice(-8)!=='electron')
{
const cliArgs=process.argv.slice(1);
let parsePositionalOnly=false;
// process CLI options prior to running up any GUI
for (var arg in process.argv) {
switch(process.argv[arg]) {
for (const arg of cliArgs) {
if (parsePositionalOnly)
{
App.cliArguments.push(arg);
continue;
}
switch(arg) {
case '--version': {
let minskyVersion=backendSync("minsky.minskyVersion");
if (minskyVersion===version)
Expand All @@ -224,13 +232,30 @@ export default class App {
}
}
break;
case '--':
parsePositionalOnly=true;
break;
default:
// pass argument on for an initial model load
if (process.argv[arg][0]!=='-')
App.cliArguments.push(process.argv[arg]);
if (arg.startsWith('--'))
{
// pass unknown command line flags through to Electron/Chromium
const flag=arg.replace(/^-+/, '');
if (flag.length>0)
{
const splitAt=flag.indexOf('=');
if (splitAt>=0)
app.commandLine.appendSwitch(flag.slice(0, splitAt), flag.slice(splitAt+1));
else
app.commandLine.appendSwitch(flag);
}
}
else if (arg[0]!=='-')
// pass argument on for an initial model load
App.cliArguments.push(arg);
break;
}
}
}

// we pass the Electron.App object and the
// Electron.BrowserWindow into this function
Expand Down
Loading