Skip to content

🌱 chore: lower file-size ratchet baselines to current line counts - #43

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
quality/test-ratchet-lower-baseline
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
quality/test-ratchet-lower-baseline

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

The file-size ratchet (crux#20) only blocks growth past the recorded baseline. Four grandfathered files have shrunk well below theirs since the baseline was captured, and the gate on main has been printing shrink notices asking for exactly this edit:

file baseline now unguarded regrowth
agent/manager.go 1825 1689 136 lines
agent/manager_kick.go 1613 1389 224 lines
agent/manager_restart.go 1001 857 144 lines
config/agent_runtime.go 1365 1295 70 lines

Until the baseline follows them down, a sync could add up to 224 lines back into manager_kick.go and the ratchet would stay green. Hive has no file-size ratchet of its own for src/crux, so this baseline is the only guard.

Values are the ones check-file-size-ratchet.sh prints on main today; hive@v5 src/crux currently has the same counts, so nothing in flight is behind this.

Verification

  • bash .github/scripts/check-file-size-ratchet.sh → file-size ratchet: ok, no shrink notices remaining
  • bash .github/scripts/test-file-size-ratchet.sh → all assertions passed

Merge note

Per the baseline header (crux#22): if a sync lands on main between this PR's last check and its merge, rebase (or just re-run the ratchet on the merge ref) first — a sync that grows one of these four files past its new number would turn main red after merge.

Scaffolding-only change under .github/; no Go files touched, so the sync guard does not apply.

— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88

Four grandfathered files have shrunk since the baseline was captured
(agent/manager.go 1825→1689, agent/manager_kick.go 1613→1389,
agent/manager_restart.go 1001→857, config/agent_runtime.go 1365→1295).
Until the baseline follows them down, each may regrow by up to 224 lines
without the ratchet noticing. These are the exact values the gate prints
in its shrink notices on main today.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified rather than inferred:

  • wc -l on crux main @ 28f098d gives 1689 / 1389 / 857 / 1295 for the four files — identical to the new baselines, and check-file-size-ratchet.sh on main prints shrink notices asking for exactly these four edits (.github/scripts/check-file-size-ratchet.sh:75 is the branch that emits them).
  • The merge-time concern from the baseline header (crux#22) does not apply right now: hive@v5 src/crux has the same four counts, so there is no in-flight sync that would regrow any of them past the new numbers.
  • Counting method matches: the script uses wc -l (check-file-size-ratchet.sh:50), same as the values in the diff.

Scaffolding-only under .github/; no Go files touched. Nothing blocking from my side.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me. Verified independently rather than from the PR body:

  • wc -l on crux main @ 28f098d: agent/manager.go 1689, agent/manager_kick.go 1389, agent/manager_restart.go 857, config/agent_runtime.go 1295 — exactly the four new values in .github/go-file-size-ratchet.txt.
  • hive@v5 src/crux has the same four counts, so no in-flight sync is behind this.
  • bash .github/scripts/check-file-size-ratchet.sh on main prints precisely these four shrink notices and ok; with this diff applied, no notices remain.

Only the baseline file changes; the ratchet script and its test are untouched. Nothing else to flag.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 585e4b3 into main Oct 29, 2026
15 of 16 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#43a293b2f` sha256:e2167e9167f5417beae44ea830d160e486a06f2f5b67b32e99acc34e82cdd554 — download from the dashboard or `hivectl review evidence #43`.

@kubestellar-prow
kubestellar-prow Bot deleted the quality/test-ratchet-lower-baseline branch October 29, 2026 03:22
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/080-awaiting-merge-admission CI green, verdict approve, no modifiers; the automerge lane has not admitted it yet labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/XS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants