Repository navigation
🌱 chore: lower file-size ratchet baselines to current line counts - #43
Conversation
Four grandfathered files have shrunk since the baseline was captured (agent/manager.go 1825→1689, agent/manager_kick.go 1613→1389, agent/manager_restart.go 1001→857, config/agent_runtime.go 1365→1295). Until the baseline follows them down, each may regrow by up to 224 lines without the ratchet noticing. These are the exact values the gate prints in its shrink notices on main today. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Looks correct to me. Verified rather than inferred:
wc -lon cruxmain@ 28f098d gives 1689 / 1389 / 857 / 1295 for the four files — identical to the new baselines, andcheck-file-size-ratchet.shonmainprints shrink notices asking for exactly these four edits (.github/scripts/check-file-size-ratchet.sh:75is the branch that emits them).- The merge-time concern from the baseline header (crux#22) does not apply right now:
hive@v5src/cruxhas the same four counts, so there is no in-flight sync that would regrow any of them past the new numbers. - Counting method matches: the script uses
wc -l(check-file-size-ratchet.sh:50), same as the values in the diff.
Scaffolding-only under .github/; no Go files touched. Nothing blocking from my side.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me. Verified independently rather than from the PR body:
wc -lon cruxmain@ 28f098d:agent/manager.go1689,agent/manager_kick.go1389,agent/manager_restart.go857,config/agent_runtime.go1295 — exactly the four new values in.github/go-file-size-ratchet.txt.hive@v5 src/cruxhas the same four counts, so no in-flight sync is behind this.bash .github/scripts/check-file-size-ratchet.shonmainprints precisely these four shrink notices andok; with this diff applied, no notices remain.
Only the baseline file changes; the ratchet script and its test are untouched. Nothing else to flag.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Why
The file-size ratchet (crux#20) only blocks growth past the recorded baseline. Four grandfathered files have shrunk well below theirs since the baseline was captured, and the gate on
mainhas been printing shrink notices asking for exactly this edit:agent/manager.goagent/manager_kick.goagent/manager_restart.goconfig/agent_runtime.goUntil the baseline follows them down, a sync could add up to 224 lines back into
manager_kick.goand the ratchet would stay green. Hive has no file-size ratchet of its own forsrc/crux, so this baseline is the only guard.Values are the ones
check-file-size-ratchet.shprints onmaintoday;hive@v5src/cruxcurrently has the same counts, so nothing in flight is behind this.Verification
bash .github/scripts/check-file-size-ratchet.sh→file-size ratchet: ok, no shrink notices remainingbash .github/scripts/test-file-size-ratchet.sh→ all assertions passedMerge note
Per the baseline header (crux#22): if a sync lands on
mainbetween this PR's last check and its merge, rebase (or just re-run the ratchet on the merge ref) first — a sync that grows one of these four files past its new number would turnmainred after merge.Scaffolding-only change under
.github/; no Go files touched, so the sync guard does not apply.— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88