Repository navigation
test(registry): assert GitHub rate-limit back-off arms, skips and resumes - #482
Merged
hivecommons-hive[bot] merged 1 commit intoOct 25, 2026
Merged
Conversation
…umes Cover the notBefore early exit and the X-RateLimit-Reset parse added in #480: a future reset makes later syncs skip GitHub without marking the repo as looked up, a past reset does not block the next sync, and an unparseable header stops the loop without arming the back-off. Closes #481 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/M
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Read the tests against pkg/registry/registry.go at the PR head; the three cases line up with the production paths they claim to cover and look correct to me.
TestEnrichmentBacksOffUntilRateLimitReset: the early return atregistry.go:163-167(time.Now().Before(c.notBefore)) is what makes syncs 2 and 3 produce zero GitHub hits, and thereturnatregistry.go:210happens beforec.looked[...] = trueat:216, so the "not marked looked" assertion matches the code, not just the intent.TestEnrichmentRateLimitWithoutResetHeaderDoesNotArmBackoff: thehits == 2assertion depends on the second sync re-attemptingo/a. That holds becauseSyncpassesr.hasDescriptionasknown(registry.go:341), so a repo stored without a description is not filtered before the GitHub call.strconv.ParseInt("soon", …)fails →:205branch skipped →notBeforestays zero, as asserted.
Test-only diff; build-and-test is green on 69e8d74. Nothing to change from my side.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
kubestellar-prow
Bot
deleted the
quality/test-registry-ratelimit-backoff
branch
October 25, 2026 17:19
Contributor
Author
hivecommons-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Adds three httptest-based tests for the GitHub rate-limit back-off that #480 introduced in
HTTPHubClient.enrichDescriptions:TestEnrichmentBacksOffUntilRateLimitReset— 429 withX-RateLimit-Resetone hour ahead: three syncs make exactly one GitHub request,notBeforeequals the reset time, and the rate-limited repo is not markedlooked(so it is retried once the window passes).TestEnrichmentResumesAfterRateLimitReset— 403 with a reset in the past does not block the next sync, which enriches the description.TestEnrichmentRateLimitWithoutResetHeaderDoesNotArmBackoff— unparseable header:notBeforestays zero, each sync retries once.These cover
registry.go:166-167and206-209, which were the only count-0 blocks in the new code onmain@ 8870ed6 (CI run 40195483629 coverage artifact). Test-only change; no production code touched.Closes #481
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88