Skip to content

Review backlog (intent-alignment): Empty-string package no longer acts as wildcard #524

Closed

Description

@hivecommons-hive

Blocked on PR #521. This finding came from reviewing PR #521 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #521.

PR: #521 (#521)
Perspective: intent-alignment
Severity: info (P3)
Evidence: scripts/npm-audit-gate.ts:127 (

return `${id.toUpperCase()}:${pkg ?? "*"}`;
)
Finding: Empty-string package no longer acts as wildcard

Pre-PR, !ex.package treated package: "" as unscoped; exceptionKey (scripts/npm-audit-gate.ts:126-128) uses pkg ?? "*", so "" yields key ID: which matches no advisory and lands in unused. loadExceptions (scripts/npm-audit-gate.ts:186-193) does not validate package, so this is latent; not a behaviour the issue covers.

Fingerprint: 7e88e4bf111d15e9f93bd068e2cc947559c76aaea3bf378b19801b02552111bf

filed by Hive review backlog

Activity

  1. added
    agent/reviewerCreated by Hive for agent-filed issue provenance
    blockedCreated by Hive for agent-filed issue provenance
    on Oct 30, 2026
  2. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #523: both cite scripts/npm-audit-gate.ts, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #521 is no longer open. This issue is actionable again.

  4. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  5. hivecommons-hive commented on Oct 30, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #521 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions