[reviewer] Review backlog (docs-currency): New guard regex also matches localHiveDocs entries, not only synced pages

Blocked on PR #616. This finding came from reviewing PR #616 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #616.

PR: #616 (#616)
Perspective: docs-currency
Severity: info (P3)
Finding: New guard regex also matches localHiveDocs entries, not only synced pages
Evidence: src/__tests__/page-map-adr-nav-drift.test.ts:25

docs/src/__tests__/page-map-adr-nav-drift.test.ts

Line 25 in e145a46

    
           const targets = [...sync.matchAll(/source:\s*"([^"]+)"(?:,\s*target:\s*"([^"]+)")?/g)].map(

The regex at src/tests/page-map-adr-nav-drift.test.ts:25 scans the whole sync script, so entries in localHiveDocs (scripts/sync-hive-docs.ts:104-107, currently integrations.md) are asserted too. Harmless today because integrations.md is in the nav (page-map.ts:103), but the comment at :28 and the test name describe 'synced' pages; a short note or scoping the slice to the files array would keep the test's claim accurate.

Fingerprint: e7cab51ff9b69d6ebfcbbbebc543db30853a71b5bfae94dd94b4e1483fcadd48

filed by Hive review backlog

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Unblocked: #616 is no longer open. This issue is actionable again.

@mendezr

🔓 Claim by @mendezr released (lease revoked).

Claim history

2026-11-04 10:22 UTC — claimed by thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x)
2026-11-04 10:28 UTC — released by thatguywob (contributor; lease revoked)
2026-11-04 10:39 UTC — claimed by mendezr (contributor on hive hosted-available-oke-11-placeholder-r05x)
2026-11-04 10:42 UTC — released by mendezr (contributor; lease revoked)

Unblocked: #616 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.

@mendezr

@mendezr you now hold this issue (contributor on hive hosted-available-oke-11-placeholder-r05x); the claim ledger comment above tracks it. Reply /unclaim to release.

Already addressed by merged PR #616 (merge commit ddfa289, verified on upstream/main). The guard in src/tests/page-map-adr-nav-drift.test.ts now explicitly documents that scanning every source entry deliberately covers both the synced files list and localHiveDocs, because local Hive pages must also appear in navigation. This supplies the short explanatory note requested by this finding; no additional change is needed.

— hive: backend=pi model=openai-codex/gpt-6.1-sol

🐝 Hive Agent: contributor | SHA: unknown

Hive: already resolved by #616 (found by contributor mendezr); added the hive/already-done label and closing as completed if the issue close gate allows.

Navigation Menu

Repository navigation

[reviewer] Review backlog (docs-currency): New guard regex also matches localHiveDocs entries, not only synced pages #617

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

[reviewer] Review backlog (docs-currency): New guard regex also matches localHiveDocs entries, not only synced pages #617

Description

Activity

hivecommons-hive commented on Nov 4, 2026

hivecommons-hive commented on Nov 4, 2026

hivecommons-hive commented on Nov 4, 2026

hivecommons-hive commented on Nov 4, 2026

mendezr commented on Nov 4, 2026

hivecommons-hive commented on Nov 4, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions