Repository navigation
[reviewer] Review backlog (correctness): listUpstreamDocs ignores the trees API truncated flag #619
Description
Blocked on PR #618. This finding came from reviewing PR #618 and is about code that PR is changing. Fix it in the PR, or leave it: when the PR merges the hive checks whether the finding is still on the base branch — closing this item as completed if its file or symbol is gone, lifting the block otherwise — and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #618.
PR: #618 (#618)
Perspective: correctness
Severity: low (P3)
Finding: listUpstreamDocs ignores the trees API truncated flag
Evidence: scripts/sync-hive-docs.ts:360
docs/scripts/sync-hive-docs.ts
Line 360 in a504803
The recursive trees response is parsed as .tree without checking truncated. If the hive repo ever exceeds the API cap (100k entries / 7MB), the listing is silently partial: siblings are missed and referenced pages are dropped by the !upstream.has(source) filter (line 285), including in heal mode where the run would still succeed. Live v5 tree today is 9,637 entries, truncated:false, so this is a hardening note, not a current defect.
Fingerprint: 41dbe471abfc45ddd28de99c1f79e509bc1ceb68af5bee19fbd9412e54db5d30
filed by Hive review backlog
Activity
hivecommons-hive commentedon Nov 4, 2026
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.
Unblocked: #618 is no longer open. This issue is actionable again.
Already fixed on
mainby #618 (merged, head dd1e57b):scripts/sync-hive-docs.tsnow declarestruncated?: booleanon the trees response (line 370) andlistUpstreamDocsthrowsupstream tree listing truncated: <url>when it is set (lines 372–373), so a partial listing can no longer silently drop pages via the!upstream.has(source)filter. Closing as completed; no further PR needed.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Nov 4, 2026
Unblocked: #618 merged and the finding's file is still on the base branch. This item is actionable now; check the finding still applies first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Nov 4, 2026
🔓 Claim by @thatguywob released (lease revoked).
Claim history
thatguywob(contributor on hive hosted-available-oke-11-placeholder-r05x)thatguywob(contributor; lease revoked)hivecommons-hive commentedon Nov 5, 2026
Additional finding (folded in — same finding area and category). Raised in the Hive review of PR #625 (#625) and folded into this issue because it is a correctness finding at the same symbol or lines of
scripts/sync-hive-docs.tsas this issue. Address it together with this issue; if it turns out to be a different problem, file it separately before closing.[reviewer] Review backlog (correctness): Healed ADR pages appended flat rather than into the ADR group
scripts/sync-hive-docs.ts:341)Perspective: correctness
Severity: low (P3)
Finding: Healed ADR pages appended flat rather than into the ADR group
Evidence:
scripts/sync-hive-docs.ts:341docs/scripts/sync-hive-docs.ts
Line 341 in fef7be8
addToHiveNav (scripts/sync-hive-docs.ts:341) always splices before the last ' ]' of the final section, so a healed adr/00NN-*.md sibling lands directly under Reference instead of inside the nested 'Architecture Decision Records' array. The ADR guard regex still passes; cosmetic nav placement only.
Fingerprint:
6fb8e4a791c9a621b9e47466b5265dbc3c2c6050380151ad41144ed4393e1ae6filed by Hive review backlog