Repository navigation
test: cover crux route lookup and reference-definition link fallbacks - #492
Merged
hivecommons-hive[bot] merged 1 commit intoOct 27, 2026
Merged
Conversation
getProjectFromPath's /docs/crux arm (added in #490) and rewriteDocLinks' reference-style definition fallbacks (added in #488) were the only lines and branches left unexecuted in those two files. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →
|
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
kubestellar-prow
Bot
deleted the
quality/test-crux-route-and-ref-def-fallbacks
branch
October 27, 2026 08:57
Contributor
Author
hivecommons-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Covers the two spots left unexecuted by last day's merges, so both files are back to 100% statements/branches:
src/config/versions.ts:220-221—getProjectFromPath("/docs/crux…")→PROJECTS.crux(added by docs: add Crux section #490) was never executed; theit.eachtable now includes/docs/cruxand a nested crux path.src/lib/rewriteDocLinks.ts:74— the reference-style definition rewriter (added by fix(docs): resolve relative doc links to absolute routes on nav-alias pages #488) only had the "doc link with title" case. Added: a definition without a title (rest ?? ""fallback) and definitions that must be left unchanged (external URL, root-absolute, asset with extension — theresolved === null ? matcharm).Evidence:
npx vitest run --coverageonmain@179f987reportsversions.tsline 221 / branch 220 andrewriteDocLinks.tsbranch 74 uncovered; with this change the targeted run reports both files fully covered (121/121 stmts, 94/94 branches). Full suite: 1308 → 1312 pass; repo gate 99/99/96/98 unaffected.No issue was filed: the repository's vitest thresholds already gate coverage and are green — this is a direct top-up, not a gap finding.
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88