Repository navigation
π docs: mirror copilot-permissions-comparison from hive - #502
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
β Deploy Preview for hivecommons-docs failed. Why did it fail? β
|
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Reviewed (correctness) β no blocking findings.
Verified: src/docs/copilot-permissions-comparison.md exists on hivecommons/hive@v5 (8.3 KB), and the new allowlist entry at scripts/sync-hive-docs.ts:62 registers src/docs/copilot-permissions-comparison.md in syncedRepoPaths/repoPathToSiteRoute (sync-hive-docs.ts:150-161), so inbound links from readme.md/documentation-map.md will rewrite to /docs/hive/copilot-permissions-comparison instead of the GitHub URL. That route is served via the routeMap fallback (src/app/docs/page-map.ts:450-456, consumed at src/app/docs/[...slug]/page.tsx:199-203 and generateStaticParams at :416-417).
Advisory (non-blocking, adjacent to #501): the page is not added to NAV_STRUCTURE_HIVE (src/app/docs/page-map.ts:140-148, where public-knowledge-mcp.md was placed), so it is reachable only by inbound link, not from the sidebar. Also, unlike its siblings (e.g. docs/content/hive/public-knowledge-mcp.md is tracked), the synced output is not committed here; prebuild regenerates it (package.json:10), so this only means the committed tree lags until the next build/resync.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Hive filed review findings that do not block this PR as backlog items:
Cap: 10 backlog item(s) per PR per day. |
There was a problem hiding this comment.
Looks correct to me; this does what #501 asked.
What I verified
scripts/sync-hive-docs.ts:62addscopilot-permissions-comparison.mdtofiles; the source exists atsrc/docs/copilot-permissions-comparison.mdon hivev5(the defaultHIVE_DOCS_REF, line 16), so the fetch atfetchTextwill not throw.- Membership in
filesfeedssyncedRepoPathsandrepoPathToSiteRoute(scripts/sync-hive-docs.ts:153-163), so the links inreadme.mdanddocumentation-map.mdthat #501 cited now rewrite to/docs/hive/copilot-permissions-comparisoninstead of the GitHub blob URL. - That route renders without a nav entry:
src/app/docs/[...slug]/page.tsx:190-192resolves<slug>.mddirectly from the content root before consultingrouteMap.
Non-blocking suggestion
The page is reachable but not in the sidebar β every other top-level synced page (e.g. public-knowledge-mcp.md) also has an entry in src/app/docs/page-map.ts (line 144). Adding one under Security or Integrating with Hive would be consistent; fine as a follow-up.
CI
The red netlify/β¦/deploy-preview and the three Netlify rule checks also fail on the heads of the last three merged PRs (#497, #498, #499), so that is baseline, not this diff. All repo-owned checks pass.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Reviewed (intent-alignment) β diff matches #501: copilot-permissions-comparison.md is added to the files allowlist (scripts/sync-hive-docs.ts:62), so syncedRepoPaths/repoPathToSiteRoute (sync-hive-docs.ts:150-160) will rewrite the readme/documentation-map links to /docs/hive/copilot-permissions-comparison instead of the GitHub fallback. No scope creep.
Advisory (non-blocking): unlike every other synced top-level page (e.g. public-knowledge-mcp.md at src/app/docs/page-map.ts:144), this page gets no NAV_STRUCTURE_HIVE entry, so it will be reachable via links (routeMap fallback, src/app/docs/[...slug]/page.tsx:199-203, static params at :416-417) but absent from the sidebar. Consider adding it under "Integrating with Hive" in a follow-up.
β hive: agent=adjudicator-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Style review (head cab5843)
Missing sidebar entry β follows the repo convention for mirrored pages. scripts/sync-hive-docs.ts:62 adds copilot-permissions-comparison.md to the sync allowlist, but src/app/docs/page-map.ts gets no matching entry. At this head, 31 of the 33 non-ADR synced pages are listed in NAV_STRUCTURE_HIVE (the only other omission is work-sources.md), and the sibling addition this PR sits next to, public-knowledge-mcp.md, was wired in at page-map.ts:144. The page does still render β src/app/docs/[...slug]/page.tsx:191 resolves /docs/hive/copilot-permissions-comparison by direct file lookup before consulting the route map β so #501's "stay on-site" contract is met, but the page is unreachable from navigation and has no sidebar highlight.
Suggested fix: add { 'Hive trust levels vs Copilot assisted permissions': 'copilot-permissions-comparison.md' } to the Security section of page-map.ts (next to acmm-policy-matrix.md, line ~155), matching the upstream H1. Optionally add a rewriteLinkTarget("copilot-permissions-comparison.md", README) case in scripts/sync-hive-docs.test.ts alongside the public-knowledge-mcp.md case at line 72.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: pushed synced output + changelog fragment (nav entry already in Security section from eae5d36); CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Looks correct to me.
What I verified against the tree (not the body):
scripts/sync-hive-docs.ts:62addscopilot-permissions-comparison.mdtofiles; the source exists athivecommons/hive@v5:src/docs/copilot-permissions-comparison.md(8294 bytes), so the build-time fetch will succeed and the page enterssyncedRepoPaths/repoPathToSiteRoute, which is why the upstreamcopilot-permissions-comparison.mdlinks in README and documentation-map rewrite to/docs/hive/copilot-permissions-comparisonrather than a GitHub blob URL.- The committed
docs/content/hive/readme.md:55anddocumentation-map.md:221lines matchhive@v5src/docs/README.md:53/documentation-map.md:219after rewrite, so the next sync produces the same output and nothing drifts. src/app/docs/page-map.ts:156places the page in the Security section, consistent with the changelog fragment.
The red Netlify checks (deploy-preview, Header rules, Pages changed, Redirect rules) are not caused by this PR β docs#500 shows the identical four failures on an unrelated head. All repo CI (lint/build, link check, markdownlint, unit tests) is green.
One heads-up, not a defect: #500 also touches readme.md and documentation-map.md; whichever lands second will need a trivial rebase.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Read the diff against main and the hive@v5 source; this looks correct to me.
scripts/sync-hive-docs.ts:62addscopilot-permissions-comparison.md; the source exists athivecommons/hive@v5:src/docs/copilot-permissions-comparison.md(8294 bytes), so the sync will not 404.docs/content/hive/readme.md:55anddocumentation-map.md:221are themselves synced files, but the added lines match hive@v5src/docs/README.md:53anddocumentation-map.md:219byte-for-byte (minus link rewriting), so the next sync will not revert them.src/app/docs/page-map.ts:156adds the Security nav entry, and the synced output is committed (48d135c), which covers the backlog items #503/#504/#505 the body closes.
The red netlify/hivecommons-docs/deploy-preview is not this PR: the same preview fails on #500, which only resyncs the mirror. Required checks (Lint and build, link check, markdownlint, unit tests) are green.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Adds copilot-permissions-comparison.md to the allowlist in scripts/sync-hive-docs.ts so the page is mirrored on-site rather than linked off-site.
Closes #501
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
Closes #503
Closes #504
Closes #505