Skip to content

πŸ› fix: mirror the split labels and dashboard-sections subpages - #540

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-538
Oct 31, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-538

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

hive@v5 split labels-and-control-signals.md and dashboard-sections.md into subdirectories. The sync allowlist listed only the parent files, so the mirror produced stubs whose links were rewritten to github.com.

This adds the six subpages to the allowlist, wires them into the Dashboard nav in page-map.ts, and extends the sync test. Docs content is not regenerated here; the next scheduled refresh (#537) populates the new pages.

Closes #538

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@netlify

netlify Bot commented Oct 31, 2026

Copy link
Copy Markdown

❌ Deploy Preview for hivecommons-docs failed. Why did it fail? β†’

Name Link
πŸ”¨ Latest commit e81af2a
πŸ” Latest deploy log https://app.netlify.com/projects/hivecommons-docs/deploys/6ae592503320d888825638e8

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the sync script and the docs router at this head; this looks correct to me.

What I verified

  • All six new sources exist on hive@v5 (src/docs/dashboard-sections/{overview-and-metrics,workflow-and-agents,activity-monitor}.md, src/docs/labels-and-control-signals/{reference,stage-labels,glossary-and-operations}.md) β€” fetched each from raw.githubusercontent.com, 200.
  • Nested sources are already a supported shape: integrations/*.md entries at scripts/sync-hive-docs.ts:64-66, and main() does fs.mkdirSync(path.dirname(targetPath), { recursive: true }) at scripts/sync-hive-docs.ts:257.
  • The parent stubs' links (dashboard-sections.md β†’ dashboard-sections/overview-and-metrics.md) now resolve via syncedRepoPaths β†’ repoPathToSiteRoute (scripts/sync-hive-docs.ts:189-191) to /docs/hive/dashboard-sections/overview-and-metrics instead of falling through to the github.com blob URL β€” which is the bug #538 describes.
  • A file and a same-named directory coexist on the router: src/app/docs/[...slug]/page.tsx:185 resolves slug.join('/') + '.md', so hive/dashboard-sections and hive/dashboard-sections/overview-and-metrics both serve. Same precedent as integrations.md + integrations/.
  • Until #537 resyncs content, the new nav entries are harmless: src/app/docs/page-map.ts:374 only emits a nav node when allDocFiles.includes(value), so missing files are skipped, not 404-linked.

Checks: Lint and build, Check internal doc links, TypeScript & ESLint, Run unit tests all green. The four red Netlify checks (deploy-preview, Header rules, Pages changed, Redirect rules) fail identically on #537, a docs-only bot PR, so that is a repo-wide deploy-preview/bot-ignore condition and not something in this diff.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

Hive status β€” updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from reviewer (folded here because this head already carries its hive review):

Read the diff against the tree and the link-rewrite path; this looks correct to me.

  • All six new source entries exist on hivecommons/hive@v5 under src/docs/ (checked each raw URL; 200s).
  • Nested sources are an existing pattern in this allowlist (integrations/*, adr/* at scripts/sync-hive-docs.ts:64-93), and repoPathToSiteRoute / syncedRepoPaths (scripts/sync-hive-docs.ts:151-163) derive from files, so the parent stubs' relative links (dashboard-sections/overview-and-metrics.md resolved against src/docs/dashboard-sections.md) now resolve to /docs/hive/... instead of falling through to github.com β€” which is the issue's symptom.
  • No basename collisions in basenameToSiteRoute among the new files.
  • npx vitest run scripts/sync-hive-docs.main.test.ts passes locally (5/5).

The red Netlify deploy-preview / header / redirect / pages-changed checks are not from this diff: #537 (unrelated file set, same window) fails the same four with the same "Deploy failed" message. Worth a maintainer glance at the Netlify build log before merging, but the GitHub-side checks (lint/build, link check, tsc/eslint, unit tests) are all green.

@hivecommons-hive
hivecommons-hive Bot merged commit 06f59e0 into main Oct 31, 2026
7 of 12 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-538 branch October 31, 2026 07:11
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#540e81af2a` sha256:8cec8febb6d6896ee0f70450fee68ceb6870e91b2cd21592e6e1d4ea5017a476 β€” download from the dashboard or `hivectl review evidence #540`.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 31, 2026
hivecommons-hive Bot added a commit that referenced this pull request Oct 31, 2026
Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
hivecommons-hive Bot added a commit that referenced this pull request Oct 31, 2026
* πŸ“– docs: resync the Hive docs mirror from hive@v5

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* πŸ“– docs: sync Hive subpages and rewrite links per #540

Hive-Fix-Attempt: 1/6

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>

---------

Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: hivecommons-hive <280983584+hivecommons-hive@users.noreply.github.com>
Co-authored-by: hivecommons-hive[bot] <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/S

Projects

None yet

0 participants