Repository navigation
🌱 test: assert DocPage falls back to this repo for banner-less pages - #541
Merged
Merged
Conversation
#536 changed the source-link fallback in DocPage, but its only test drove DocsSourceActions with a hand-supplied URL, so reverting page.tsx leaves the suite green. Render /docs/hive/governor (no 'Synced from' banner) through the route and assert the View Source / Compose a PR targets, alongside a synced page that must keep its upstream URL. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
❌ Deploy Preview for hivecommons-docs failed. Why did it fail? →
|
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Read the test against src/app/docs/[...slug]/page.tsx:318-323 and ran it locally; this looks correct to me.
- The test exercises the real third arm (
page.sourceUrl ?? …/docs/content/${projectId ?? 'hive'}/${filePath}), not a hand-suppliedsourceUrl, so it closes the gap left byDocsSourceActions.test.tsx. - Verified the body's claim: 2/2 pass at
8c49b24; withpage.tsxreverted to6d63684^the governor case fails (links resolve tohivecommons/hive/.../governor.md). The syncedgetting-startedcase still passes either way, which is the right contrast. - Mock setup (
next/navigation,next/link, hoistednextra/compilestub,DocsProvider+renderToStaticMarkup) matchesdocs-slug-page.general-section-source-links.test.tsxexactly. - Fixtures are stable against the open resync #537: it does not touch
hive/governor.md, andhive/getting-started.mdkeeps its banner on that branch.
The red Netlify statuses are the [context.deploy-preview].ignore rule at netlify.toml:53 matching quality/* (Netlify reports a skipped preview as error), not something this diff caused.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Contributor
Author
hivecommons-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Follow-up to #536. That fix changed how
DocPagecomputes the "View Source" / "Compose a PR" target for pages with noSynced frombanner, but its only test exercisedDocsSourceActionswith a hand-suppliedsourceUrl— reverting thepage.tsxfallback leaves the whole suite green (verified locally: the new test fails against6d63684^, passes atmain).This adds a route-level test that renders
/docs/hive/governor(authored here, no banner) and asserts the action links targethivecommons/docs/.../docs/content/hive/governor.md, plus the contrasting synced page (getting-started) that must keep its upstream URL.compileMdxis stubbed to fail so the page takes its<pre>arm and the test stays fast (~2s).Test-only: no changelog fragment per
changelog.d/README.md. Full suite: 1372 passed, coverage unchanged at 99.8% lines / 97.53% branches.Refs #536 (already merged; this adds the missing regression test for it)
Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88