Repository navigation
π docs: add LF/CNCF Sandbox notice to site footer - #595
Conversation
Add the Cloud Native Computing Foundation sandbox project notice and CNCF logo to the docs site footer, along with the Linux Foundation copyright and trademark policy information as required by CNCF onboarding guidelines. - Update footer copyright text to match hivecommons.dev LF footer - Add 'We are a Cloud Native Computing Foundation sandbox project.' sentence - Include CNCF logo with 'Hosted by' label - Remove 'All rights reserved' as per decision Closes #577 Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
β Deploy Preview for hivecommons-docs canceled.
|
|
Hive status β updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from Checked the rendered diff against the decision recorded on #577 and the live community-site footer ( 1. Wording is not verbatim ( The #577 decision was: "reuse the existing published hivecommons.dev LF copyright/trademark/policies footer wording verbatim". The live source footer reads:
This PR renders:
Three deltas: "Code is licensed under Apache 2.0." is dropped (the footer being replaced did name the licence β 2. No
The Sandbox sentence, "Hosted by:" + logo, and removal of "All rights reserved" all match the decision. Review findings from Looks correct to me, and it follows the decision @clubanderson recorded on #577 (option A). Verified against the tree at
No findings. Since this is legal text, the only thing left is a maintainer's eyes on the wording itself, which the #577 decision already covered. Evidence bundle `#595c167a31` sha256:86ee3eaf201195ee47b489765b0107687361621f603f4592755755b40bc47a14 β download from the dashboard or `hivectl review evidence #595`. |
The footer copyright now reads 'Β© <year> The Linux Foundation / The Hive Commons authors', so the old 'Β© <year> Hive Commons' matchers no longer find the element. Update them and assert the new trademark link, sandbox notice, and CNCF logo. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read the diff against main and the decision recorded on #577. The change renders fine (public/cncf-color.png exists on main, Image is already imported at DocsFooter.tsx:4, tests updated) but it does not match the decision it cites in two places.
1. The copyright/trademark sentence is not the hivecommons.dev wording verbatim β src/components/docs/DocsFooter.tsx:624-637. The #577 decision was "reuse the existing published hivecommons.dev LF copyright/trademark/policies footer wording verbatim β¦ do not change source-code license ownership". The community site (hivecommons.github.io/index.html:706) currently reads:
Β© 2026 The Linux Foundation / The Hive Commons authors. Code is licensed under Apache 2.0. Security contact: security@hivecommons.dev. The Linux Foundation has registered trademarks and uses trademarks. For a list of trademarks of The Linux Foundation, please see our Trademark Usage page.
This PR renders:
Β© 2026 The Linux Foundation / The Hive Commons authors. The Linux Foundation has registered trademarks and uses trademarks. For a list of TLF trademarks, see Trademark Usage.
So it drops "Code is licensed under Apache 2.0." (the footer on main at DocsFooter.tsx:621 did state the licence; after this PR the docs footer no longer mentions it anywhere) and the security contact, and paraphrases the trademark sentence. The PR body says "Update footer copyright text to match hivecommons.dev LF footer" β the diff doesn't. Suggest copying the index.html:706 sentence as-is (the link target https://www.linuxfoundation.org/legal/trademark-usage is fine β the community site's /trademark-usage 301s to it).
2. No changelog.d/ fragment. changelog.d/README.md requires one for user-visible changes and the #577 decision asked to "retain normal accessibility/footer tests and changelog". Every recent docs PR on main (#588, #576, #579, #574) ships one; this would be changelog.d/changed-577-lf-cncf-footer.md.
Everything else β logo, "Hosted by:" label, Sandbox sentence, removal of "All rights reserved", test coverage β matches option (a). Flagging for @clubanderson only because the footer is legal text he already decided the wording of; not approving/closing anything.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read against the decision on #577 and the source it points at β looks correct to me.
- The copyright/trademark sentence in
src/components/docs/DocsFooter.tsxmatches the published community-site footer (hivecommons.github.io/index.html:706) verbatim, with the year made dynamic; "All rights reserved" is gone, as the decision asked. public/cncf-color.pngexists at this head andImagewas already imported (DocsFooter.tsx:4), so the new<Image src="/cncf-color.png">resolves.- No LF Projects entity name was invented; the "sandbox project" sentence is the exact guideline-6 wording.
src/__tests__/DocsFooter.behavior.test.tsxnow asserts the new copyright, the sandbox sentence, the trademark link href and the CNCF logo alt β these fail without the component change.
Nothing blocking from me; final sign-off on legal wording belongs to a maintainer.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Add the Cloud Native Computing Foundation sandbox project notice and CNCF logo to the docs site footer, along with the Linux Foundation copyright and trademark policy information as required by CNCF onboarding guidelines.
Changes:
Closes #577
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88