Repository navigation
📖 docs: resync the docs/content mirrors from upstream - #626
Conversation
Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
✅ Deploy Preview for hivecommons-docs canceled.
|
|
needs-human: GitHub Actions is holding this PR's workflow runs for approval, and Hive cannot start them. A maintainer can comment |
There was a problem hiding this comment.
This refresh cannot merge as-is: Run unit tests is red on head 1bdfd31 (job 127090048147), and the failures are caused by the one non-mirror change in the diff, not by flake. The mirrored markdown itself looks fine (link rewrites only, e.g. docs/content/hive/env-vars.md:129; no new scripts or external fetches).
What happened. This is the first scheduled run where heal mode actually healed: scripts/sync-hive-docs.files.json:212-217 gains integrations/cline.md and integrations/forges.md. Two things in the repo are coupled to that list and break:
-
Nav guard —
src/__tests__/page-map-adr-nav-drift.test.ts:20("lists every synced page in NAV_STRUCTURE_HIVE") fails becausesrc/app/docs/page-map.tsstill lists onlyintegrations/clanker-flue.md(:157); the two healed pages are synced but not in the nav. This is exactly the contradiction #625 fixes for future heals; it does not retroactively fix this PR, and the refresh workflow'sadd-pathsdoes not includepage-map.tsanyway. -
Drift tests use the live manifest as a fixture —
scripts/sync-hive-docs.main.test.ts:327-333buildsupstream = [...listed, "integrations/cline.md", "integrations/forges.md", …]from the realsync-hive-docs.files.jsonand then asserts those two names are reported as unlisted (:375,:378,:408,:410,:433). Now that they are listed, five tests fail on assertions likeexpected … not to contain 'integrations/cline.md'. Same pattern atsync-hive-docs.drift.test.ts("records src/docs markdown pages that Case 2 pushed to GitHub" — expects a GitHub URL forforges.md, gets/docs/hive/integrations/forges). The tests hard-code real upstream filenames that heal mode was always going to add.
Suggested path (a maintainer or the hive needs a separate PR to main; this bot branch is regenerated daily and only carries mirror paths):
- add
{ 'Cline': 'integrations/cline.md' }and{ 'Forges': 'integrations/forges.md' }(titles per each page's first#) to the integrations section ofNAV_STRUCTURE_HIVEinsrc/app/docs/page-map.ts; - switch the drift fixtures in
sync-hive-docs.main.test.ts/sync-hive-docs.drift.test.tsto synthetic names (e.g.integrations/zz-fixture-a.md) or filter them againstlisted, so they stop depending on what upstream happens to ship.
Once that lands on main, the next daily refresh regenerates this branch and should go green. @clubanderson flagging since you are the OWNERS approver; I have not changed anything.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
…fixtures Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: guide <280983584+hivecommons-hive[bot]@users.noreply.github.com>
…nary The rewriteLinks unsynced-reference test relied on integrations/forges.md being absent from sync-hive-docs.files.json; the resync now mirrors that page, so the link rewrote to a site route and the assertion failed. Use a name no upstream page will ever carry, matching the main() fixtures. Also wrap the stubFetch ternary that exceeded Prettier's printWidth. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor. hive/awaiting-ci: pushed a prettier-only fixup for 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 Review findings from docs-currency re-review @ 6ddeeef (delta from 1bdfd31) Fixed: Still blocking — the delta leaves CI red at this head:
Review findings from Delta re-review (intent-alignment), read at 6ddeeef and the newer head fc5e70f. Previous findings: all three are fixed — One in-scope blocker remains — the fix commits leave CI red on the same files they touch:
Scope otherwise matches the title: the mirror resync plus the nav/test follow-ups the previous review asked for; no unrelated changes. Review findings from The only red check ( I reproduced it against this head (
Not a defect, for context: the hand-added nav entries in |
There was a problem hiding this comment.
Still red at 6ddeeef, for two concrete reasons; both are one-step fixes.
1. scripts/sync-hive-docs.drift.test.ts:233-247 has the same fixture collision the fix commit removed from main.test.ts. The rewriteLinks unsynced-reference collection test still uses the real integrations/forges.md as its "unsynced" page (line 233, [a](integrations/forges.md)) and asserts it is pushed to a GitHub URL (line 246-248). But the resync commit 1bdfd31 healed integrations/forges.md into scripts/sync-hive-docs.files.json (+6 lines, entries for integrations/cline.md and integrations/forges.md), so rewriteLinks now resolves it to the site route and CI fails exactly there:
AssertionError: expected '[a](/docs/hive/integrations/forges) …' to contain '[a](https://github.com/hivecommons/hi…' at drift.test.ts:247. Renaming the fixture to a synthetic page (e.g. integrations/drift-sibling-b.md, matching what 6ddeeef did in main.test.ts:332-333) in lines 233, 234, 240-253 fixes it.
2. Prettier. The TypeScript & ESLint job fails only on [warn] scripts/sync-hive-docs.main.test.ts — npx prettier --write scripts/sync-hive-docs.main.test.ts and recommit.
Context for maintainers: this PR is the first real heal run, and it shows the exact gap #625 closes — heal appended two pages to files.json without touching src/app/docs/page-map.ts, so the #616 nav guard failed and 6ddeeef had to add the two nav lines by hand (page-map.ts:159-160). Those two lines match what #625's addToHiveNav would generate ({ '<first # heading>': '<target>' }), so landing #625 and adding page-map.ts to the workflow's add-paths (#627) stops this from recurring.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Automated daily resync of the committed mirrors under
docs/content/via
npm run sync-hive-docsandnpm run sync-sibling-docs.This PR was opened with
GITHUB_TOKEN, so GitHub does not startpull_requestworkflows for it. The refresh run instead dispatchesBuild, TypeScript & Lint Check, Vitest, npm audit, Internal Links
and Markdown Lint on the PR branch; their check-runs land on the
head SHA as usual.
Refresh run: https://github.com/hivecommons/docs/actions/runs/41980614246
Refs #496
The hive sweep merges this PR once CI is green.