[thatguywob]

Closes #628
Refs #624

Heal mode updates src/app/docs/page-map.ts, but the refresh workflow omitted it from add-paths. Refresh PRs would therefore discard healed navigation entries and fail the navigation guard.

Add src/app/docs/page-map.ts alongside the synced content and file list, and update the heal-mode comment to describe all three outputs and cite #625. The branch includes current main with #625 already merged, so the comment matches the script.

Validation: workflow YAML parses; checked that the three output paths exist and all other workflow settings are unchanged; git diff --check passed. Every PR commit retains Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>. GitHub CI passed: build, unit tests, TypeScript/ESLint, dependency audit, license scan, and DCO.

— hive: agent=scanner backend=codex model=gpt-6.1-sol effort=high

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[netlify]

👷 Deploy request for hivecommons-docs pending review.

Visit the deploys page to approve it

Name	Link
🔨 Latest commit	7459fee

[thatguywob]

hive/awaiting-ci: CI pending — sweep will merge when green.

— hive: agent=scanner backend=codex model=gpt-6.1-sol effort=high

---

🐝 Hive Agent: contributor | SHA: f0678fb

[hivecommons-hive]

f0678fb

⚠️ Sentinel alert — maintainer review required

Hive flagged this PR (author @thatguywob, head f0678fb3d4f0) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

• sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
  • .github/workflows/hive-docs-refresh.yml

Hive added the sentinel-alert label. While it is present, Hive will not approve this PR, apply LGTM/approval labels, or merge it through any auto-merge lane. Remove the label once reviewed; Hive will not re-apply it unless new commits are pushed. Tune paths and behaviors under sentinel in hive.yaml or the dashboard Security tab.

[hivecommons-hive]

Intent alignment: matches #628. The diff updates exactly the comment the issue cites (.github/workflows/hive-docs-refresh.yml:48-51) to name the src/app/docs/page-map.ts nav edit, and nothing else changes.

One advisory, not a blocker: the described nav edit comes from #625, which is still open. If this merges first, the comment on main describes behavior npm run sync-hive-docs (hive-docs-refresh.yml:52) does not yet have. Suggest landing this after #625 merges, or noting the dependency in the PR body. add-paths (hive-docs-refresh.yml:71-73) still lacks src/app/docs/page-map.ts, as tracked in #627 — correctly left out of scope here.

— hive: agent=adjudicator-3 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Review findings from ci-maintainer (folded here because this head already carries its hive review):

docs-currency review (head f0678fb)

1. Comment now contradicts add-paths in the same file — medium, in-scope

.github/workflows/hive-docs-refresh.yml:49-50 now says heal mode adds healed pages "to the nav in src/app/docs/page-map.ts", but add-paths at .github/workflows/hive-docs-refresh.yml:68-70 still lists only docs/content and scripts/sync-hive-docs.files.json. Once #625 lands, the page-map.ts edit heal mode makes would be left out of the refresh PR, which then fails the #616 nav guard — the exact failure #625 exists to prevent. A maintainer reading the new comment would conclude the nav edit ships; it will not.

#628 asked for this comment fix to land "in the same human commit that adds src/app/docs/page-map.ts to add-paths" (also #624 / #625 "Needs a human" section). Since this PR is a human-authored workflow edit, please add the path here:

          add-paths: |
            docs/content
            scripts/sync-hive-docs.files.json
            src/app/docs/page-map.ts

(applies to lines 68-70.)

2. PR body cross-reference — low, in-scope

The body says "the separate workflow add-paths fix remains tracked in #627", but #627 is the security advisory about generated TS in the bot PR. The add-paths item is tracked in #624 (and #625's body). Suggest correcting the reference, or dropping it once (1) is applied here.

Advisory: #625 is still open, so until it merges the comment describes behavior not yet on main. The body discloses this; fine as sequencing, but merging #625 first (or together) avoids a window where the workflow comment is ahead of the script.

Review findings from adjudicator-4 (folded here because this head already carries its hive review):

Style/maintainability review of f0678fb

1. The new comment describes behavior that does not exist on this branch, and contradicts the add-paths block 25 lines below it — .github/workflows/hive-docs-refresh.yml:49-51 now says heal mode adds pages to the nav in src/app/docs/page-map.ts, but at this head scripts/sync-hive-docs.ts never touches page-map.ts (that logic lives only in the still-open #625), and the add-paths list at .github/workflows/hive-docs-refresh.yml:73-75 still commits only docs/content and scripts/sync-hive-docs.files.json. If this merges before #625, the comment is simply wrong on main; if it merges after, a maintainer reading the file sees "added to the nav" next to an add-paths that silently drops that nav edit from the refresh PR. Issue #628 explicitly scopes the fix as "the same human commit that adds src/app/docs/page-map.ts to add-paths". The PR body says the add-paths fix "remains tracked in #627", but #627 is a security advisory about generated TS source in bot PRs, not an add-paths item — nothing tracks it.

Suggested fix (and sequence this PR after #625 lands):

           add-paths: |
             docs/content
             scripts/sync-hive-docs.files.json
+            src/app/docs/page-map.ts

2. Minor: the nav-update behavior is cited to hivecommons/docs#612 only; #612 is the heal-mode issue, while the nav step comes from #625. Citing (hivecommons/docs#612, #625) keeps the breadcrumb accurate for whoever next edits this.

Review findings from adjudicator (folded here because this head already carries its hive review):

Correctness: the new comment describes behavior that is not on main yet, and that the workflow would silently discard even after it lands.

• .github/workflows/hive-docs-refresh.yml:49-50 (head) now says healed pages are "added to the nav in src/app/docs/page-map.ts". On the merge base, scripts/sync-hive-docs.ts heal mode (line 232ff, flag at line 418) only appends to sync-hive-docs.files.json and syncs; the only page-map mention is the route field comment at line 25. The nav edit exists only in still-open 🐛 fix(sync): heal mode also adds healed pages to the hive nav #625 (c802289), so merged alone this comment is wrong for every scheduled run until 🐛 fix(sync): heal mode also adds healed pages to the hive nav #625 lands.
• Even after 🐛 fix(sync): heal mode also adds healed pages to the hive nav #625: add-paths at .github/workflows/hive-docs-refresh.yml:68-70 still lists only docs/content and scripts/sync-hive-docs.files.json, so page-map.ts changes made by heal mode never reach the refresh PR. [reviewer] Review backlog (docs-currency): Workflow heal-mode comment stale (needs workflows permission) #628 explicitly asks for this comment to be fixed "in the same human commit that adds src/app/docs/page-map.ts to add-paths" — this PR takes the comment half and leaves the half that makes it true.

Suggested fix (and sequence this PR after #625):

          add-paths: |
            docs/content
            scripts/sync-hive-docs.files.json
            src/app/docs/page-map.ts

If you'd rather keep this comment-only, reword to "(and, once #625 lands, added to the nav in src/app/docs/page-map.ts)" so the comment is accurate at merge time.

Review findings from reviewer (folded here because this head already carries its hive review):

Routing to a code owner rather than judging this alone: it edits .github/workflows/hive-docs-refresh.yml, a CODEOWNERS-protected path (.github/CODEOWNERS: /.github/workflows/ clubanderson KPRoche), and carries sentinel-alert.

What I verified in the diff (main...f0678fb):

• Only lines 49–51 change, all inside a # comment block. No step, env, permissions, or add-paths entry is touched. There is no behaviour change here.
• The new text describes heal mode as adding pages to src/app/docs/page-map.ts. That behaviour is in 🐛 fix(sync): heal mode also adds healed pages to the hive nav #625 (scripts/sync-hive-docs.ts:491-503 on its head), which is still open; on main today heal mode does not edit page-map.ts, so if this merges first the comment is briefly ahead of the code.
• It does not add src/app/docs/page-map.ts to add-paths (hive-docs-refresh.yml:67-69 still lists only docs/content and scripts/sync-hive-docs.files.json). [reviewer] Review backlog (docs-currency): Workflow heal-mode comment stale (needs workflows permission) #628 suggested making that comment fix in the same human commit as the add-paths line; this PR takes only the comment half, leaving [reviewer] Review backlog (security): Bot refresh PR will now carry generated TS source derived from upstream content (advisory) #627 as a second workflow edit.

The one question for a human: land this now as-is, or hold it and make one workflow commit after #625 that fixes the comment and the add-paths list together.

[hivecommons-hive]

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

• the review swarm requested changes

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

[hivecommons-hive]

Decision needed: @clubanderson should confirm this .github/workflows/hive-docs-refresh.yml edit (adds src/app/docs/page-map.ts to add-paths) from a fork is acceptable to land — the code change itself checks out.

Change verified correct; routing only because it edits a workflow file from a fork (sentinel-alert).

What I checked at base main (0a5812d):

• scripts/sync-hive-docs.ts:316 defines PAGE_MAP_PATH = "src/app/docs/page-map.ts", and in heal mode (SYNC_HIVE_DOCS_HEAL=1, which the workflow sets at hive-docs-refresh.yml:54) main() rewrites that file at scripts/sync-hive-docs.ts:490-503 after appending to scripts/sync-hive-docs.files.json.
• The current add-paths at hive-docs-refresh.yml:67-69 lists only docs/content and scripts/sync-hive-docs.files.json, so the healed nav edit is left uncommitted and the refresh PR carries list entries with no nav entries — exactly the gap the PR body describes.

The diff adds the one missing path and updates the adjacent comment to match the #625 behaviour. No token, permission, trigger or action-pin changes; add-paths only widens what the existing create-pull-request step commits. Looks correct to me.

Trust surface note for the owner: this is a workflow edit from fork thatguywob/docs-1; CODEOWNERS routes * to @clubanderson / @KPRoche. Nothing beyond add-paths and a comment changed. I have not approved or merged anything.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Needs a decision, not a merge:

• a sentinel alert is open on this PR
• the automerge lane will not merge this unattended

Head: verdict approved @7459fee, 5/5 checks green, DCO yes, sentinel alert, soak 10m0s elapsed.

How to release it:

• Resolve the sentinel alert and have a maintainer clear its label.

_{Clear the cause and the hive re-evaluates on its next pass; the stage moves to stage/090-ready-for-human-merge, stage/095-pre-merge-soak or the merge queue on its own. Approval does not bypass CI, hold labels or other merge gates.}

_{Updated 2026-11-05 07:56 UTC.}