Skip to content

[scanner] [shared-ci] test (agent */5) failing across hivecommons/hive — fork-PR shards on ubuntu-latest (now ubuntu-26.04 / tmux 3.6a) fail tmux restart-readiness tests #14406

Closed

Description

@hivecommons-hive

Shared CI incident

TestPollTmuxOutputForAgent_WiresThrashBreaker (src/crux/agent/thrash_poller_wiring_test.go:110) fails 3/3 runs (including gotestsum re-runs) on three unrelated open PRs, while it passes on the v5 default branch.

PR shard it landed in diff touching src/crux/agent/
#14383 test (agent 3/5) adds bob_launch_shell_test.go only
#14391 test (agent 4/5) adds ci_poll_log_read_test.go + manager_kick.go
#14403 test (agent 2/5) adds ci_poll_wall_clock_test.go + manager_kick.go

Evidence:

Why one issue, not three PR repairs

Same test, same message, three PRs whose diffs do not touch the poller or the breaker; baseline green. This is a test-isolation / shard-composition defect in the test suite, not a defect in any of the three PRs. The three fork PRs are deferred against this issue rather than retried.

Ask

  • Make TestPollTmuxOutputForAgent_WiresThrashBreaker independent of shard composition (own tmux socket via -L, or a unique session name and a guard that no other test in the package reuses the server), or mark it testutil.SkipfUnlessRequired behind the integration gate like its siblings.
  • Until then, treat its red as needs-signal: the check has failed ≥3 times with no code cause.

Risk: none (test-only).

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Activity

  1. added
    kind/testCategorizes issue or PR as related to testing.
    agent/scannerCreated or modified by the scanner agent
    ciApproved by a Hive merger/owner for auto-merge on green CI
    needs-signalHive needs a better CI or test signal before continuing
    on Oct 26, 2026
  2. added
    help wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
    on Oct 26, 2026
  3. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by @thatguywob (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  4. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by @thatguywob released (lease revoked).

  5. changed the title [-][scanner] [shared-ci] test (agent */5) failing across hivecommons/hive — TestPollTmuxOutputForAgent_WiresThrashBreaker is shard-composition dependent[/-] [+][scanner] [shared-ci] test (agent */5) failing across hivecommons/hive — fork-PR shards on ubuntu-latest (now ubuntu-26.04 / tmux 3.6a) fail tmux restart-readiness tests[/+] on Oct 26, 2026
  6. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    Root cause corrected: runner image, not shard composition

    The "shard-composition dependent" reading above was wrong. The discriminator between red and green test (agent */5) jobs is which runner the job landed on:

    job runner image result
    #14383 test (agent 3/5) (job 121753920450) GitHub Actions / ubuntu-latest Image: ubuntu-26.04 red
    #14383 test (agent 1,2,4,5/5) ubuntu-latest ubuntu-26.04 green (no tmux-restart tests in those shards)
    #14402 test (agent 1-5/5) hive-runners-lke-qh55w-runner-* self-hosted green
    v5 push 40388216857 test (agent 1-5/5) hive-runners-lke-* self-hosted green

    v2-tests.yml sends fork PRs to the 'ubuntu-latest' fallback and everything else to vars.HIVE_RUNNER_LABELS (hive-runners-lke). GitHub rolled ubuntu-latest from ubuntu-24.04 (tmux 3.4) to ubuntu-26.04 (tmux 3.6a-2ubuntu0.2) on 2026-10-26 (first observed ~18:00Z). Fork PRs are the only hive runs that hit it, which is why the three affected PRs are all fork PRs and every same-repo sibling and v5 push is green — regardless of shard.

    Independent confirmation: hivecommons/crux (the src/crux mirror, GitHub-hosted only) went red on main at the same hour with agent/ unchanged between the green and red syncs, failing TestSendKick_RestartsCrashedCLIThenDelivers, TestRestartThenSendKick_CleanSlateThenDelivers, TestRestart_CancelsPendingAsyncKick, TestStartDrainsDeferredKickWithoutBootstrapPrompt — the tmux launch/restart readiness path (hivecommons/crux#8).

    What to do

    • Short term: pin the fork-PR fallback in v2-tests.yml runs-on expressions from 'ubuntu-latest' to 'ubuntu-24.04' (workflow edit — needs a human; the App token cannot push .github/workflows/*). crux carries the same pin in its own CI.
    • Follow-up: find which tmux 3.6a / 26.04 behaviour waitForCLIReadyForAgent → capture-pane depends on so the pin can be lifted.

    The needs-signal ask stands, reworded: the missing signal is the runner image in the failure annotation.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  7. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    Second symptom on the same image, logged here so the incident covers it: fork PR #14365 test (rest 4/5) (job 121798360071, ubuntu-latest = ubuntu-26.04) fails TestHiveOpenPRScript_MultilineBodyIsValidJSONWithoutPython3 with bin/hive-open-pr.sh: line 59: dirname: command not found, while the identical test passes on the v5 push for a67f21d (job 121813067197, hive-runners-lke). The PR does not touch bin/, src/pkg/github/ or the test. Whatever lets the stub-PATH test resolve dirname on 24.04/self-hosted does not hold on the 26.04 image; the durable fix is to add dirname to the test's stub tool list (it is a real dependency of the script's SCRIPT_DIR line) — PR-sized, filed for the next cycle alongside the agent-package investigation.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  8. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    A merged PR referenced this issue without closing it. Carrying the remainder back here so the issue timeline shows what is still open.

    Remainder from the PR body:

    (second symptom only: the agent-package tmux failures on ubuntu-26.04 remain open on the issue)

    This comment is edited in place by the task-list sweep on every cycle; it is not duplicated.

  9. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    Fixed by #14429 (merged 0c0218b). Closing. Reply /reopen if the problem persists.

  10. hivecommons-hive commented on Oct 26, 2026

    @hivecommons-hive
    ContributorAuthor

    /reopen

    The problem persists for the first symptom. #14429 fixed only the dirname half (TestHiveOpenPRScript_MultilineBodyIsValidJSONWithoutPython3), but TestPollTmuxOutputForAgent_WiresThrashBreaker still fails 3/3 runs on every fork PR whose shard picks it up on ubuntu-latest, while v5 stays green:

    PR shard run
    #14431 test (agent 2/5) head 193a1ee
    #14395 test (agent 2/5) head a32b38f
    #14440 test (agent 2/5) head ba94a7f
    #14444 test (agent 4/5) head 9758fd7
    #14454 test (agent 4/5) head d059167
    #14456 test (agent 5/5) head 71d7049

    The fix for this half is #14415 (isolates the wiring test on its own tmux socket), which is green and sitting at stage/090-ready-for-human-merge — the merge relay refuses it under the contributor-lane tier policy, so it needs a human merge. Once #14415 lands these PRs only need a base sync. The same three tests (TestRestart_CancelsPendingAsyncKick, TestRestartThenSendKick_CleanSlateThenDelivers, TestPollTmuxOutputForAgent_WiresThrashBreaker) also fail in hivecommons/crux#6 go test ./agent (ubuntu-latest), so the crux mirror needs the #14415 + #14431 test changes synced forward too.

    Keeping this open as the single incident until #14415 merges.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

  11. kubestellar-prow commented on Oct 26, 2026

    @kubestellar-prow
    Contributor

    @hivecommons-hive[bot]: Reopened this issue.

    Details

    In response to this:

    /reopen

    The problem persists for the first symptom. #14429 fixed only the dirname half (TestHiveOpenPRScript_MultilineBodyIsValidJSONWithoutPython3), but TestPollTmuxOutputForAgent_WiresThrashBreaker still fails 3/3 runs on every fork PR whose shard picks it up on ubuntu-latest, while v5 stays green:

    PR shard run
    #14431 test (agent 2/5) head 193a1ee
    #14395 test (agent 2/5) head a32b38f
    #14440 test (agent 2/5) head ba94a7f
    #14444 test (agent 4/5) head 9758fd7
    #14454 test (agent 4/5) head d059167
    #14456 test (agent 5/5) head 71d7049

    The fix for this half is #14415 (isolates the wiring test on its own tmux socket), which is green and sitting at stage/090-ready-for-human-merge — the merge relay refuses it under the contributor-lane tier policy, so it needs a human merge. Once #14415 lands these PRs only need a base sync. The same three tests (TestRestart_CancelsPendingAsyncKick, TestRestartThenSendKick_CleanSlateThenDelivers, TestPollTmuxOutputForAgent_WiresThrashBreaker) also fail in hivecommons/crux#6 go test ./agent (ubuntu-latest), so the crux mirror needs the #14415 + #14431 test changes synced forward too.

    Keeping this open as the single incident until #14415 merges.


    🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

    — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

    Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

  12. github-actions commented on Oct 26, 2026

    @github-actions
    Contributor

    Reopened at the request of @hivecommons-hive[bot], who reported this issue.If this was closed by a merged PR, first check whether the fix has reached you: it only takes effect after it ships in a tagged release and your deployment updates to it. If your running version already contains the fix and the problem persists, please add whatever you are still seeing (running version, logs, steps) so it is not closed the same way again. See #6762 for why this command exists.

  13. github-actions commented on Oct 27, 2026

    @github-actions
    Contributor

    @hivecommons-hive[bot] this issue was closed by @kubestellar-prow[bot] as completed.

    If this was closed by a merged PR, the fix only takes effect once it ships in a tagged release and your deployment updates to it — check your running version against the fix before concluding the fix failed.

    If you are still seeing the problem, comment /reopen and it will be reopened for you — you do not need write access. Please add what you are still observing (running version, logs, steps) so it is not closed the same way again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/scannerCreated or modified by the scanner agentciApproved by a Hive merger/owner for auto-merge on green CIhelp wantedDenotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.kind/testCategorizes issue or PR as related to testing.needs-signalHive needs a better CI or test signal before continuing

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions