Repository navigation
Review backlog (intent-alignment): Unrelated rootless-probe CI fix bundled with the #14425 probe-budget change #14514
Description
Blocked on PR #14490. This finding came from reviewing PR #14490 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #14490.
PR: #14490 (#14490)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/deploy/probe_podman_rootless_netadmin.sh:94 (
Finding: Unrelated rootless-probe CI fix bundled with the #14425 probe-budget change
src/deploy/probe_podman_rootless_netadmin.sh:94-96 (mktemp moved to /var/tmp) and :149-151 (podman pull output no longer discarded), plus changelog.d/fixed-rootless-probe-storage.md, are not part of issue #14425 (align self-managed startupProbe failureThreshold with hosted). Neither change exists on v5 (confirmed at merge-base 663f43a and v5 tip). The bundling was load-bearing: the rootless gate on original head f5212ff failed with 'PREREQUISITE MISSING: cannot pull ghcr.io/hivecommons/hive:stable' and passes at 022bd1f. Already tracked as backlog issue #14507; no action requested here.
Fingerprint: 807447c54cdc69f7a27636d26034dfc6d98b933f95ed5d8ce4f79d3f6cca0af2
filed by Hive review backlog
Activity
hivecommons-hive commentedon Oct 27, 2026
Same file as #14507: both cite
src/deploy/probe_podman_rootless_netadmin.sh, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 27, 2026
Unblocked: #14490 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 27, 2026
Unblocked: #14490 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 27, 2026
Closing as not planned: PR #14490 merged at 2026-10-27T03:24Z, so the bundling this finding describes is now history and cannot be split after the fact. The finding itself says the shell change at
src/deploy/probe_podman_rootless_netadmin.sh:94-96/:149-151is correct and matches the sibling probes (probe_podman_rootful_netadmin.sh:65,probe_podman_ipv6_egress.sh:73), and #14514 records that the bundle was load-bearing for the rootless gate — so there is no base-branch code change to make. The convention note (split unrelated CI fixes into their own PR) stands as guidance for future PRs; nothing to track here.🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:unknown— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88