Review backlog (intent-alignment): Legacy WorkflowRefusedHeadSHA records stop on head alone, ignoring base moves

Blocked on PR #14401. This finding came from reviewing PR #14401 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14401.

PR: #14401 (#14401)
Perspective: intent-alignment
Severity: info (P3)
Evidence: src/pkg/holdguard/holdguard.go:380 (

hive/src/pkg/holdguard/holdguard.go

Line 380 in a13a0c6

return e.UpdateStoppedReason, true

)
Finding: Legacy WorkflowRefusedHeadSHA records stop on head alone, ignoring base moves

Entry.UpdateStoppedFor (src/pkg/holdguard/holdguard.go, new code after line 354) returns stopped whenever WorkflowRefusedHeadSHA == headSHA regardless of baseSHA, so a record written by the previous build keeps skipping that PR even after main moves and the workflows 403 might no longer apply. The PR body discloses this ('Legacy records'); bounded to pre-existing records and self-heals on the next head push. Advisory only.

Fingerprint: a4abdc8f3a28ce8bf20b7de30e55e39b73bca3357dce01cf0d61d956dbf20b10

filed by Hive review backlog

Unblocked: #14401 is no longer open. This issue is actionable again.

@Karibhou

🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

@Karibhou

🔓 Claim by @Karibhou released (lease revoked).

🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

Unblocked: #14401 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

Closed by #14536 (merged to v6).

Navigation Menu

Repository navigation

Review backlog (intent-alignment): Legacy WorkflowRefusedHeadSHA records stop on head alone, ignoring base moves #14533

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Review backlog (intent-alignment): Legacy WorkflowRefusedHeadSHA records stop on head alone, ignoring base moves #14533

Description

Activity

hivecommons-hive commented on Oct 27, 2026

hivecommons-hive commented on Oct 27, 2026

hivecommons-hive commented on Oct 27, 2026

hivecommons-hive commented on Oct 27, 2026

hivecommons-hive commented on Oct 27, 2026

github-actions commented on Oct 27, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions