Review backlog (style): Enumeration-path held PRs carry neither MergeableState nor BaseSHA; upkeep only runs from webhook-derived held PRs

Blocked on PR #14535. This finding came from reviewing PR #14535 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #14535.

PR: #14535 (#14535)
Perspective: style
Severity: info (P3)
Evidence: src/pkg/github/client.go:2024 (

hive/src/pkg/github/client.go

Line 2024 in d17fe50

}

)
Finding: Enumeration-path held PRs carry neither MergeableState nor BaseSHA; upkeep only runs from webhook-derived held PRs

src/pkg/github/client.go:1993-2024 builds heldPRs without MergeableState or BaseSHA, so maintainHeldPRMergeability skips them at the state check; only webhook_item_patch.go:160,172 populates both. Pre-existing asymmetry. If MergeableState is later added to the enumeration copy, BaseSHA must be added too or IsHygieneMerge will reject every hygiene merge and the baseline will never advance.

Fingerprint: 9f836cd67ba480afd4d9535a42463b083d32d2179c55ef73add3a35f5989998f

filed by Hive review backlog

Unblocked: #14535 is no longer open. This issue is actionable again.

Unblocked: #14535 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

Re-triaged after #14535 merged (the PR this was blocked on).

Already fixed on v5 by #14535 itself: the enumeration-path held-PR copy now sets BaseSHA: pr.GetBase().GetSHA() (src/pkg/github/client.go:2016 at 62d4a09fb), and pr.BaseSHA is also populated on the per-PR hydrate path (client.go:2391). The hazard this finding warned about — MergeableState being added to the enumeration copy without BaseSHA, so IsHygieneMerge rejects every hygiene merge — can no longer occur.

MergeableState remains unset on the list path by design: GitHub's list-pulls payload does not carry mergeable_state (it is only on the single-PR GET), so maintainHeldPRMergeability correctly runs only from webhook/hydrated held PRs. Closing as already resolved; no PR needed.

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: 62d4a09fb

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Navigation Menu

Repository navigation

Review backlog (style): Enumeration-path held PRs carry neither MergeableState nor BaseSHA; upkeep only runs from webhook-derived held PRs #14538

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Review backlog (style): Enumeration-path held PRs carry neither MergeableState nor BaseSHA; upkeep only runs from webhook-derived held PRs #14538

Description

Activity

hivecommons-hive commented on Oct 27, 2026

hivecommons-hive commented on Oct 27, 2026

hivecommons-hive commented on Oct 27, 2026

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions