Skip to content

🐛 fix: exclude automerge configuration drift from runtime reports - #14352

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
arteeh:fix/14351-automerge-override-warning
Oct 26, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
arteeh:fix/14351-automerge-override-warning

Conversation

@arteeh

@arteeh arteeh commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Repeated automerge required_checks override does not match repo protection warnings currently qualify as runtime-error self-reports even though the merge gates already use actual repository protection checks. Treat this specific configuration drift notice as benign for the generic self-report feed while preserving its operator warning and diagnostics.

Add regression coverage for the reported five-warning burst, case-insensitive classification, preserved log output, and continued reporting of actual protection lookup failures. Include a changelog fragment.

Related issues

Fixes #14351

Testing

  • gofmt -l on changed Go files: no output.
  • Not run locally: CI runs validation for agent-authored PRs (AGENTS.md forbids local builds/tests in agent panes).
  • Regression tests added in pkg/fleetreport and pkg/fleetreport/slogfeed; CI validation pending.

Contributor checklist

  • Changelog fragment added.
  • Targets v5; title follows the emoji convention.
  • Commit includes matching DCO sign-off and Hive trailers.
  • No secrets, credentials, or local runtime state committed.

— hive: backend=codex model=gpt-6.1-sol effort=medium


🐝 Hive Agent: contributor | SHA: 00aa21814

Keep stale required_checks warnings in operator logs while excluding them from the generic repeated runtime-error feed. Cover the reported burst and ensure protection lookup failures remain reportable.

Hive-Run: #14351
Hive-Plan: required-checks-selfreport-classification
Hive-Spec: #14351#evidence
Signed-off-by: arteeh <arteeh@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 26, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2026
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 26, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14347 🐛 fix(fleetreport): exclude expected agent GitHub quota warnings same files src/pkg/fleetreport/fleetreport.go
src/pkg/fleetreport/slogfeed/slogfeed_test.go

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the tree at 00aa218, not just the diff. This looks correct to me.

  • Both emit sites log the exact substring added to benignSubstrings (fleetreport.go:761): pkg/github/automerge/automerge_sweep.go:2785 and pkg/github/merge_ci_gate.go:283. Both are once-per-repo deduped (requiredChecksFallbackWarned / requiredChecksMismatchWarned) and log "using", "actual" — the gate already decides on live protection, so the message is operator config drift, not a runtime defect. The classification matches what the issue (#14351) reports.
  • IsBenignMessage lowercases before strings.Contains (fleetreport.go:769-781), so the case-insensitive test case holds.
  • slogfeed.Handler.feed returns early for benign messages before h.observe (slogfeed/slogfeed.go:106-110) while Handle still forwards to the wrapped handler, so the warning stays in logs — the new TestRequiredChecksOverrideMismatchLogsWithoutFleetReport asserts exactly that path.
  • Negative cases (automerge failed to read repo protection, etc.) don't contain the substring and remain reportable.

Changelog fragment name follows fixed-<pr>-<slug>.md. No concerns.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 26, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit 55516d6 into hivecommons:v5 Oct 26, 2026
70 of 75 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#1435200aa218` sha256:3bf4a121d0c9fc9da9405cfd5d0b7fd155db3b8c1bfb06de775bd5f2ca266d5a — download from the dashboard or `hivectl review evidence #14352`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @arteeh holds the trusted tier in this hive's contributor registry.

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: automerge required_checks override does not match repo protection

1 participant