Repository navigation
🐛 fix: exclude automerge configuration drift from runtime reports - #14352
hivecommons-hive[bot] merged 1 commit into
Conversation
Keep stale required_checks warnings in operator logs while excluding them from the generic repeated runtime-error feed. Cover the reported burst and ensure protection lookup failures remain reportable. Hive-Run: #14351 Hive-Plan: required-checks-selfreport-classification Hive-Spec: #14351#evidence Signed-off-by: arteeh <arteeh@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read the tree at 00aa218, not just the diff. This looks correct to me.
- Both emit sites log the exact substring added to
benignSubstrings(fleetreport.go:761):pkg/github/automerge/automerge_sweep.go:2785andpkg/github/merge_ci_gate.go:283. Both are once-per-repo deduped (requiredChecksFallbackWarned/requiredChecksMismatchWarned) and log"using", "actual"— the gate already decides on live protection, so the message is operator config drift, not a runtime defect. The classification matches what the issue (#14351) reports. IsBenignMessagelowercases beforestrings.Contains(fleetreport.go:769-781), so the case-insensitive test case holds.slogfeed.Handler.feedreturns early for benign messages beforeh.observe(slogfeed/slogfeed.go:106-110) whileHandlestill forwards to the wrapped handler, so the warning stays in logs — the newTestRequiredChecksOverrideMismatchLogsWithoutFleetReportasserts exactly that path.- Negative cases (
automerge failed to read repo protection, etc.) don't contain the substring and remain reportable.
Changelog fragment name follows fixed-<pr>-<slug>.md. No concerns.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Merged by hive contributor-lane auto-merge: CI green for ≥30m, reviewer verdict approve, @arteeh holds the trusted tier in this hive's contributor registry. |
Summary
Repeated
automerge required_checks override does not match repo protectionwarnings currently qualify as runtime-error self-reports even though the merge gates already use actual repository protection checks. Treat this specific configuration drift notice as benign for the generic self-report feed while preserving its operator warning and diagnostics.Add regression coverage for the reported five-warning burst, case-insensitive classification, preserved log output, and continued reporting of actual protection lookup failures. Include a changelog fragment.
Related issues
Fixes #14351
Testing
gofmt -lon changed Go files: no output.pkg/fleetreportandpkg/fleetreport/slogfeed; CI validation pending.Contributor checklist
v5; title follows the emoji convention.— hive: backend=codex model=gpt-6.1-sol effort=medium
🐝 Hive Agent:
contributor| SHA:00aa21814