Skip to content

πŸ› fix(contribute-ws): log expected resume-without-lease rejection at info - #14510

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-14478
Oct 27, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-14478

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Root cause: a task_progress resume with no matching server-issued lease (hub restart losing in-memory leases, expiry, or a stale relay) is a correct, security-required rejection (C4). The relay already self-recovers via the task_revoke sent right after, so the only defect is the log class: it was logged at Warn and fired as unclassified_error_repeated. Downgraded to Info; behavior, decision record and task_revoke are unchanged. No unit test added: the change is log-level only and no existing log-capture pattern covers this path.\n\nCloses #14478

Fixes #14478

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…info

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 27, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the handler and the log feed. This looks correct to me.

  • src/pkg/dashboard/contribute_ws.go:3552-3570 β€” the no-lease branch still records decisionResumeRejected and sends task_revoke; only the log level changes, as the body says.
  • The adjacent cool-off rejection in the same function already logs at Info (contribute_ws.go:3582), so this brings the two expected-rejection paths to the same level.
  • src/pkg/fleetreport/slogfeed/slogfeed.go:31,69 β€” the slog feed only counts records with Level >= LevelWarn, so moving to Info does stop this line from feeding unclassified_error_repeated. The body's claim checks out.

Cosmetic only: the PR body contains a literal \n before Closes #14478 and cites the issue twice (Closes/Fixes); harmless for linking.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 1b503f7 into v5 Oct 27, 2026
84 of 88 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-14478 branch October 27, 2026 02:51
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#14510f37010d` sha256:9b4ccc4931687fe094716f25260212b92fca164f69cf0686f9d90bddbeae620e β€” download from the dashboard or `hivectl review evidence #14510`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. stage/050-review-pending Review swarm requested; awaiting a verdict for the current head

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[selfreport] unclassified_error_repeated: [contribute-ws] task_progress resume rejected: no matching server-issued lease

0 participants