Repository navigation
π fix(contribute-ws): log expected resume-without-lease rejection at info - #14510
Conversation
β¦info Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of No conflicting open PRs or same-file overlaps were found. |
There was a problem hiding this comment.
Read the handler and the log feed. This looks correct to me.
src/pkg/dashboard/contribute_ws.go:3552-3570β the no-lease branch still recordsdecisionResumeRejectedand sendstask_revoke; only the log level changes, as the body says.- The adjacent cool-off rejection in the same function already logs at
Info(contribute_ws.go:3582), so this brings the two expected-rejection paths to the same level. src/pkg/fleetreport/slogfeed/slogfeed.go:31,69β the slog feed only counts records withLevel >= LevelWarn, so moving toInfodoes stop this line from feedingunclassified_error_repeated. The body's claim checks out.
Cosmetic only: the PR body contains a literal \n before Closes #14478 and cites the issue twice (Closes/Fixes); harmless for linking.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Root cause: a task_progress resume with no matching server-issued lease (hub restart losing in-memory leases, expiry, or a stale relay) is a correct, security-required rejection (C4). The relay already self-recovers via the task_revoke sent right after, so the only defect is the log class: it was logged at Warn and fired as unclassified_error_repeated. Downgraded to Info; behavior, decision record and task_revoke are unchanged. No unit test added: the change is log-level only and no existing log-capture pattern covers this path.\n\nCloses #14478
Fixes #14478
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88