[hivecommons-hive]

Closes #14493

Amends the pacing-seam comment in manager_kick.go: overrides outside TestMain are allowed when restored via t.Cleanup and no package test uses t.Parallel. Comment-only.

Finding came from the review of #14431 (merged).

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Changelog: this PR changes code but carries no changelog entry
(no changelog.d/ fragment and no CHANGELOG.md edit).

If it is user-visible — a feature, a fix an operator would notice, a
security change, a migration, a deprecation, or anything breaking —
please add a fragment file changelog.d/<category>-<pr-or-slug>.md
containing exactly your entry (see changelog.d/README.md; the
category is one of added/changed/deprecated/fixed/security). Please
do not append to CHANGELOG.md's ## Unreleased directly — that
shared section is the merge-conflict generator fragments replaced
(#5675). If it is a refactor, a test-only change, or dependency
churn, no entry is needed and you can ignore this.

This is a reminder, not a gate; it never blocks a merge.

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed (correctness) — comment-only change; verified the new claim that no test in src/crux/agent calls t.Parallel() (grep over the package at 8a8dc43 finds none), so the documented rule is sound.

One advisory accuracy note: the amended text at src/crux/agent/manager_kick.go:1155 says an override is allowed "only if it restores the original via t.Cleanup", but three existing tests restore via defer instead — agent_working_test.go:146-148, copilot_question_form_test.go:37-39, tui_menu_test.go:67-69 (only kick_cancel_test.go:237 and kick_restart_recovery_test.go:71 use t.Cleanup). Consider "restores the original (t.Cleanup or defer)" so the rule matches the code it now blesses. Non-blocking.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me — comment-only, and the claim it adds checks out against the tree at 8a8dc43.

Verified

• grep -rn 't.Parallel()' src/crux/agent/*_test.go → 0 hits, so "no test in the package uses t.Parallel" is true today.
• The two existing in-body overrides already follow the restore rule: agent_working_test.go:143-148 and copilot_question_form_test.go:34-39 save inputPromptTimeout/inputPromptPollInterval and restore them.

Two low-severity wording notes (optional)

1. src/crux/agent/manager_kick.go:1155 says the restore must be "via t.Cleanup", but both existing overrides restore with defer (lines cited above). Either is equivalent for a non-parallel, non-subtest body; consider "via defer or t.Cleanup" so the comment matches current practice rather than implying those two tests are out of compliance.
2. manager_kick.go:1156 is 123 chars; the surrounding comment block wraps at ~80. Re-wrapping the paragraph would keep it readable.

Neither blocks merge.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me — comment-only, and the claim it adds matches the tree at 8a8dc43.

Verified:

• grep -rn 't.Parallel()' src/crux/agent/*_test.go → no hits, so the "no test in the package uses t.Parallel" statement holds.
• TestMain is at manager_test.go:46; the suite-wide shrink is manager_test.go:153-163.
• Every pacing-var override outside TestMain restores the original: kick_cancel_test.go:236-237 and kick_restart_recovery_test.go:70-71 via t.Cleanup; agent_working_test.go:143-148, copilot_question_form_test.go:34-39, tui_menu_test.go:64-69 via defer.

One small accuracy note (low): the new text at manager_kick.go:1155 says "only if it restores the original via t.Cleanup", but three of the five existing overrides restore via defer, which is equivalent here since nothing runs in parallel. "via t.Cleanup (or defer)" would describe the package as it is; otherwise a reader will think those three tests violate the rule just written. Not blocking.

Also cosmetic: the amended line 1156 runs ~110 columns because the old Relationships the values encode … sentence was appended to it rather than re-wrapped.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Rewrap slip in the amended comment — src/crux/agent/manager_kick.go:1156 is 123 characters (// this is safe because no test in the package uses t.Parallel. Relationships the values encode (bobInputHandlerSettleDelay). The rest of this comment block (lines 1150–1158) and the neighbouring doc comments are hard-wrapped at ≤80 columns; the new sentence was spliced in front of the old "Relationships the values encode…" text without reflowing the paragraph. Please rewrap lines 1154–1158 so the block stays consistent (no linter enforces this, so it is readability only).

The substantive claim is verified: no _test.go under src/crux/agent/ calls t.Parallel at head 8a8dc43, and the wording matches the remedy requested in #14493.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#1451578f3454` sha256:75f2b0fdc8dc8346a0c18190a9e5d454fe474b7fc3c91e7f72831f21b2057f45 — download from the dashboard or `hivectl review evidence #14515`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback