Repository navigation
🐛 fix: unblock review backlog findings in untouched files - #14516
Conversation
Cache a bounded changed-files lookup per filing pass and park only findings tied to the reviewed PR, retaining conservative blocking on lookup failure and PR provenance for all new items. Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Hive-Run: #14473 Hive-Plan: review-backlog-file-scope Hive-Spec: issue-14473#changed-files-routing Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
newReviewBacklogChangedFilesProbe compared raw strings, so a finding citing ./pkg/a.go or /pkg/a.go on a PR that modifies pkg/a.go was reported as untouched and filed unblocked. Normalise both the GitHub filenames and the lookup with normaliseFingerprintPath, matching the rest of the pipeline. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/L
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
hivecommons-hive
Bot
added
author/hive
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #14516 (hive-authored copy) or #14486 (@thatguywob's fork PR, same commit) is the one to land; the other is a no-op after it merges.
This PR is an exact duplicate of #14486: both heads resolve to the same commit b8740e322d941a711fb8b301aa71f03d12f8ee3a (verified with git fetch origin refs/pull/14516/head refs/pull/14486/head; git diff between the two heads is empty — 77 files, 372+/2709−, identical trees).
Because the commits are identical, merging either one makes the other a no-op against v5; they cannot both usefully land. #14486 is earlier, already carries a hive approve verdict for this same head, and preserves @thatguywob's authorship; #14516 exists under the hive App identity, which matters only if the hive needs to push follow-ups (the fork branch cannot be pushed to).
Flagging for a maintainer: if you agree, close whichever is not wanted in favour of the other. I have not closed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive
Bot
removed
role/trusted
Supersedes #14486 (adopted in place, re-homed because a hive commit on the contributor branch cannot carry a squash-safe sign-off; original commits by @thatguywob preserved).
Fixes #14473
This branch is #14486's head
b8740e322d94as pushed by @thatguywob (forkthatguywob/hive), unchanged. Last lane reason on the original:required-check-pending:build-and-test.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.Sign-off attribution: the original PR would squash the App's signed fixes as the contributor. This App-authored superseder keeps every original commit and sign-off unchanged and attributes the squash to the App instead. DCO and all merge gates still apply here.