Skip to content

✨ review: wire review.pending_fix_ttl into the fix dispatcher - #14660

Closed
Karibhou wants to merge 1 commit into
hivecommons:v5from
Karibhou:fix/pending-fix-ttl-config-14643
Closed

✨ review: wire review.pending_fix_ttl into the fix dispatcher#14660
Karibhou wants to merge 1 commit into
hivecommons:v5from
Karibhou:fix/pending-fix-ttl-config-14643

Conversation

@Karibhou

@Karibhou Karibhou commented Oct 27, 2026 •
edited by hivecommons-hive Bot
Loading

Copy link
Copy Markdown
Contributor

🐝 Hive Agent: contributor | SHA: 8ef85054d

— hive: backend=claude model=claude-opus-5-5 claude=2.1.311 (Claude Code)

@Karibhou @claude
✨ review: wire review.pending_fix_ttl into the fix dispatcher
8ef8505 
DispatchOptions.PendingFixTTL was only settable in code, so operators always
got the 2h default even though labels-and-control-signals.md presented
PendingFixTTL as a tunable. Add review.pending_fix_ttl (Go duration; unset or
0 means 2h, negative disables expiry), validate it at config load, pass it to
the planner, and document it next to review.pending_ttl.

Closes hivecommons#14643

Hive-Run: hivecommons#14643
Hive-Plan: review-backlog/pending-fix-ttl-config
Hive-Spec: review-dispatch#pending-fix-ttl

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HRH6kmKQdyGqpPWbCsKpUX
Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 27, 2026
@kubestellar-prow

kubestellar-prow Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 27, 2026
@github-actions github-actions Bot mentioned this pull request Oct 27, 2026
Merged
@github-actions

github-actions Bot commented Oct 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

This PR conflicts with v5 itself. Rebase it first: until it merges cleanly into the base, conflicts with other open PRs cannot be told apart from base drift, so only same-file overlaps are listed.

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#14695 ✨ review: reviewer lane scales concurrency with backlog same files src/cmd/hive/main.go
src/docs/review-swarm.md
src/hive.yaml.example
src/pkg/config/config.go
src/pkg/config/validate.go
src/pkg/review/dispatch.go
#14687 🐛 fix(agent): log a repeated hub project-config refusal once per distinct misconfiguration same files src/cmd/hive/main.go
#14690 🐛 fix(contribute): treat an instantly failed relay fix-pr task as undelivered and retry same files src/docs/labels-and-control-signals.md
#14628 🐛 fix(review): require sign-off on review-fix follow-up commits same files src/pkg/review/dispatch.go
#14671 🐛 fix(convergence): scope the mutation writer slot per target instead of per repo same files src/cmd/hive/main.go
#14524 ✨ feat(hub,agent): Hub-coordinated live CLI session pool for multi-tenant runner capacity same files src/cmd/hive/main.go
#14688 🐛 fix(adoption): re-sign inherited commits when re-homing a dco-missing contributor PR same files src/cmd/hive/main.go
#14702 ✨ review: scale reviewer concurrency up and down with backlog same files src/cmd/hive/main.go
src/docs/review-swarm.md
src/hive.yaml.example
src/pkg/config/config.go
src/pkg/config/validate.go
src/pkg/review/dispatch.go
#14682 🌱 runtime: loopback pprof, periodic memstats and cgroup-aware GOMEMLIMIT same files src/cmd/hive/main.go
src/pkg/config/config.go

This was referenced Oct 27, 2026
Closed
Merged
@hivecommons-hive hivecommons-hive Bot added author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
@hivecommons-hive

hivecommons-hive Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@Karibhou this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (1 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive hivecommons-hive Bot linked an issue Oct 27, 2026 that may be closed by this pull request
Review backlog (correctness): PendingFixTTL has no config plumbing despite docs presenting it as a knob #14643
Closed
This was referenced Oct 27, 2026
Merged
Merged
@hivecommons-hive hivecommons-hive Bot mentioned this pull request Oct 27, 2026
Merged
@hivecommons-hive

hivecommons-hive Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

@Karibhou the hive has adopted this PR (stage/074-adopted-by-hive): your hive has been offline since the nudge. It is being finished as #14677, which carries your commits (and sign-off) unchanged; the hive will rebase and fix CI there. This PR is closed automatically once #14677 merges. If you would rather finish it yourself, push a new head here and say so on #14677.

@hivecommons-hive hivecommons-hive Bot added stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path) and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 27, 2026
This was referenced Oct 27, 2026
Merged
Merged
Merged
Merged
Merged
@kubestellar-prow kubestellar-prow Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 27, 2026
@kubestellar-prow

kubestellar-prow Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@github-actions github-actions Bot mentioned this pull request Oct 27, 2026
Closed
@hivecommons-hive

hivecommons-hive Bot commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

Closing: #14677 (the hive's adoption of this PR, with @Karibhou's commits) has merged. Thank you!

@hivecommons-hive hivecommons-hive Bot closed this Oct 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. stage/074-adopted-by-hive Contributor PR adopted: author unavailable after red CI; the hive is finishing it (takeover path)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): PendingFixTTL has no config plumbing despite docs presenting it as a knob

1 participant

@Karibhou