Repository navigation
📖 docs: re-anchor the RankActionableIssues citation in scale-envelope.md - #14712
Conversation
RankActionableIssues gained lines in #14657, so the cited 4676-4686 range no longer covers the AgeMinutes comparison and the docs-citations check on v5 fails with DRIFT. Widen the range to the function's current extent. Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
kubestellar-prow
Bot
added
the
dco-signoff: yes
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
kubestellar-prow
Bot
added
the
size/XS
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
github-actions
Bot
added
the
conflicts-with-open-pr
|
hive/awaiting-ci: CI pending — sweep will merge when green. 🐝 Hive Agent: — hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified against the tree: this fixes the red relative links and anchors resolve check and looks correct to me.
- On
v5tip,python3 src/scripts/check-docs-citations.pyreports exactly the drift this PR describes:DRIFT src/docs/scale-envelope.md:37 src/pkg/github/client.go:4676-4686 -> lacks anchor(s) near cited range: AgeMinutes. On this head the checker exits 0 (1281 repo-local file:line reference(s) verified). - The checker (
check-docs-citations.py:81-93,230-237) only requires the anchorsRankActionableIssues/AgeMinutesto appear within ±2 lines of the cited range, so4676-4693passes.
Two small notes, neither blocking:
- Range start is imprecise.
src/pkg/github/client.go:4676-4677is the tail ofActionablePriorityLabels(return labels/});RankActionableIssuesstarts at 4679 (doc comment) / 4683 (func).4679-4693or4683-4693would cite the function itself. Cosmetic — the check passes either way. - Textual conflict with #14710. #14710 (
fix: pack agents follow the hive's inference gateway) re-anchors the same line ofscale-envelope.md:37to4682-4692, bundled into an unrelated L-sized change. Whichever lands second needs a rebase. Since this PR is XS, docs-only, and unblocks the required check for every open PR, it seems the right one to land first; #14710 can then drop itsscale-envelope.mdhunk. Flagging so a maintainer can sequence them — I have not changed anything.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me, and it is the fix the rest of the queue needs: python3 src/scripts/check-docs-citations.py src/docs passes on this head (1281 citations verified) and fails on v5 with exactly the scale-envelope.md:37 … lacks anchor(s) near cited range: AgeMinutes drift.
Two small notes for whoever merges:
- The new range
4676-4693starts seven lines early. Onv5,src/pkg/github/client.go:4676-4677is the tail ofActionablePriorityLabels;RankActionableIssuesitself is4683-4693(AgeMinutesat 4691). The body says the range is "the function's current extent" — it is not quite, though the checker accepts it.4683-4693would be the exact citation. - #14710 edits the same line (
src/docs/scale-envelope.md:37, to4682-4692), so one of the two will need a rebase. This XS docs-only PR is the better one to land first; I have suggested on #14710 that it drop its copy of this hunk.
— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
hivecommons-hive
Bot
removed
role/trusted
Closes #14711
Why
The required
relative links and anchors resolvecheck is red on thev5tip (c6d82d0) and therefore on every open PR (#14614, #14630, #14670, #14706 show the identical failure). #14657 grewRankActionableIssuesinsrc/pkg/github/client.go, moving theAgeMinutescomparison to line 4691 — outside the4676-4686range cited atsrc/docs/scale-envelope.md:37(checker slack is 2 lines).check-docs-citations.py --fixonly repairsapi-reference.md, so this needed a manual re-anchor.Docs-only; widens the citation to the function's current extent (
4676-4693). No changelog fragment: nothing undersrc/changes behaviour.— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88