Repository navigation
✨ review: scale reviewer concurrency up and down with backlog - #14728
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
Add review.reviewers.autoscale. The planner records the PR heads that found every plain reviewer busy (DispatchPlan.ReviewerStarved). A clock-injected ReviewerAutoscaler turns that backlog, plus how long the oldest head has waited, into an active replica count between min and max, with streaks for hysteresis and a cooldown between steps. It holds scale-up at max, while the provider budget latch is set, when cgroup headroom is short, and for one cooldown after a reviewer kick fails with "did not reach input prompt". Dynamic replicas come from ExpandAgentReplicas, which raises the scaled agent to max without rewriting its declared replicas. Replicas above the active count take no review-swarm kick (DispatchOptions.ReplicaLimits) and no cadence kick. A turn already in flight is never interrupted, so a scaled-in replica drains. Hive-Run: #14685 Hive-Plan: review-reviewer-autoscale Hive-Spec: review-swarm#reviewer-autoscale Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01HRH6kjsZcEuDdED3kSWiqU Signed-off-by: Karibhou <Karibhou@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
This PR touches files the merged PR did not, so the hive is resolving it itself, but GitHub refused to update head c01758e onto This comment is edited in place by the supersession sweep; it is not duplicated. |
Open PR overlap checkBase branch:
Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Decision needed: @clubanderson should decide whether #14702/#14728 or #14695 is the reviewer-autoscale implementation for #14685 before the fix lane spends effort rebasing this one — they add review.reviewers.autoscale to the same files with incompatible shapes and cannot both merge.
Decision needed: @clubanderson should decide whether #14702/#14728 or #14695 is the reviewer-autoscale implementation for #14685 before the fix lane spends effort rebasing this one — they add review.reviewers.autoscale to the same files with incompatible shapes and cannot both merge.
This PR's head c01758e1d020 is the identical commit to #14702's head (the body says so and the SHAs match), so the review already posted on #14702 at that head applies verbatim here rather than being re-derived:
- Conflicts with #14695 (same issue, same config key, same six files; different demand signal, different replica-retirement mechanism, different controller package). It is a pick-one, not a rebase-and-merge-both. #14685 is @clubanderson's issue and #14695 is their implementation, so the pick is theirs.
- The red checks are the diff's fault (
TestAgentRuntimeConfigGoldenatpkg/config/agent_runtime_golden_test.go:45,TestSettingsDialogReferencesEveryHiveYAMLLeafatpkg/dashboard/settings_parity_test.go:33, coverage), so a fix agent can make them green — but only worth doing if this is the chosen implementation.
Nothing closed; flagging so the adoption does not race the decision.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Supersedes #14702 (adopted after CI went red and the contributor was unavailable; original commits by @Karibhou preserved).
Closes #14685
This branch is #14702's head
c01758e1d020as pushed by @Karibhou (forkKaribhou/hive), unchanged. Last lane reason on the original:check-failing:coverage.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.