Repository navigation
π fix(agent): exempt ci-maintainer/quality lane variants from CI-poll nudge - #14732
Conversation
β¦udge Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
|
βΈοΈ CI is red on the base branch (govulncheck (known vulnerabilities)); holding until it recovers β this is not a failure in this PR, so no fix attempt is counted and no one needs to act here. |
There was a problem hiding this comment.
Read ciPollNudgeExemptAgent and its single caller nudgeIfPollingCI (src/crux/agent/manager_kick.go:1479, :1514) on the PR head. The new exemptCIPollLane lowercases and trims before the exact / base- / base_ prefix match, so the previous EqualFold behaviour is preserved for the exact names and ci-maintainer-2, quality_full now match while ci-maintainers and scanner still do not β the table test covers exactly those cases. The review-substring exemption above it is untouched. Package builds on the head. Looks correct to me.
The red govulncheck check is the base-branch GO-2026-6860 (golang.org/x/net) finding that #14731 bumps; nothing in this diff touches dependencies.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
There was a problem hiding this comment.
Looks correct to me. Read src/crux/agent/manager_kick.go: exemptCIPollLane lowercases then matches the base lane exactly or as a -/_-suffixed prefix, so ci-maintainer-2 becomes exempt while ci-maintainers and scanner stay nudgeable β the new table test covers both sides. The caller loop over agent.Name and agent.Config.Role is unchanged.
The red build-hub (linux/amd64) check is not this diff: job 122537494813 failed in "Build and push hub image by digest" on google.golang.org/grpc@v1.83.2: read https://proxy.golang.org/...: stream error ... INTERNAL_ERROR β a module-proxy fetch flake inside the image build. A re-run should clear it.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
|
hive/awaiting-ci: π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
A ci-maintainer agent was nudged and self-reported (ci_poll_nudge) despite the lane exemption, because the exemption matched only the exact lane name. Replica/variant names (e.g. ci-maintainer-2) now match too; test added.
Closes #14719
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88