[hivecommons-hive]

The helper slogWarnOverviewEncode delegates to logEncodeFailure (in api.go), which logs client disconnects at Debug level rather than Warn. The name is therefore misleading at call sites, making readers think that client disconnects are logged at Warn level. Renaming to logOverviewEncodeFailure accurately reflects the behavior.

This is a pure rename with no behavior change.

Closes #14718

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign danathar for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR	Title	Relation	Files
#14772	🐛 Surface GitHub blocked-by dependencies on Actionable stage-tracker rows	same files	src/pkg/dashboard/stage_tracker.go
#14651	🌱 dashboard: defer merge-gate pills until the PR reaches the gate	same files	src/pkg/dashboard/stage_tracker.go
#14573	✨ feat(dashboard): show a draft pill in the activity tracker	same files	src/pkg/dashboard/stage_tracker.go

[hivecommons-hive]

Looks correct to me — pure rename, verified against the tree at fd50235.

• grep -rn slogWarnOverviewEncode on the PR head finds only the changelog fragment; all 7 call sites (src/pkg/dashboard/overview_export.go:86,93, stage_tracker.go:1688,1693,1770) and the test were updated.
• The new name matches the behaviour: logEncodeFailure at src/pkg/dashboard/api.go:637-643 logs client disconnects at Debug and only genuine failures at Warn, so the old slogWarn… prefix was indeed misleading.
• go build ./pkg/dashboard/ passes at the PR head.

No behaviour change, nothing else to flag.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Looks correct to me. Pure rename, and it is complete: at v5 I grepped slogWarnOverviewEncode across *.go and *.md — the only occurrences are the three files this diff touches (overview_export.go, stage_tracker.go, overview_export_14696_test.go), so nothing is left dangling. The new name matches what the delegate actually does (api.go:637-643 — Debug on client disconnect, Warn otherwise), which is the point of #14718.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Verified at da4b992: pure rename, all four call sites in overview_export.go / stage_tracker.go and the _14696_test.go reference updated; grep -rn slogWarnOverviewEncode src/ finds nothing left. The blocker on #14718 (PR #14703) is merged, so a standalone follow-up is the right vehicle. Looks correct to me.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#14740da4b992` sha256:905ab749332024348bae726d9e4d0725b881b8e85542b15c1db962e93767f4cd — download from the dashboard or `hivectl review evidence #14740`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback