[hivecommons-hive]

Closes #14744

Why

A cross-repo claim from crux#25 (its body mentioned #14730) closed open PR hive#14730 with a false "Fixed by #25" record. GitHub's Issues API also returns pull requests, and the claim path (and the shared close function) had no IsPullRequest() guard; only the backfill loop did.

What

closeIssueForMergedPRClaimWithIssue now skips with CloseOnMergeSkipped / target_is_pull_request (logged at INFO, as a verdict) before the state check. Existing reasons and exported names are unchanged. Adds a regression test and changelog fragment.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 requested_by=@clubanderson

[kubestellar-prow]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[github-actions]

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

[hivecommons-hive]

hive/awaiting-ci: CI pending — sweep will merge when green.

---

🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: a171b2848

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=ci-maintainer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Reviewed — no findings from this perspective.

— hive: agent=adjudicator backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read the tree at c61d45d, not just the diff. The new IsPullRequest() guard sits in the shared closeIssueForMergedPRClaimWithIssue after the Issues.Get fallback (src/pkg/github/close_on_merge.go:541), so it covers the ledger-claim path (:226, which passes issue == nil) as well as the backfill path that already filtered at :268. Because CloseOnMergeSkipped settles (:146), the sweep marks the claim settled rather than re-fetching it every pass. The test drives the claim path with a pull_request-shaped issue and asserts zero write requests, which is the right assertion for this bug. go build ./pkg/github/ passes.

Looks correct to me and matches #14744 without extra scope. Only the Sign-off-survives-the-squash runs show CANCELLED (re-run/infra, not this diff).

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Read against the v5 tree at src/pkg/github/close_on_merge.go; this looks correct to me.

• The claim path (closeIssueForMergedPRClaim, called from the sweep at close_on_merge.go:226) fetches the target via Issues.Get and went straight to the issue_not_open state check. Only the backfill loop had the issue.IsPullRequest() filter (close_on_merge.go:268), so a cross-repo claim naming a PR number could close that PR. The new guard sits after the issue_not_found branch and before the state check, which is the right spot: a not-found target still reports issue_not_found, and a PR target now short-circuits before any write.
• CloseOnMergeSkipped is already in the terminal-action list at close_on_merge.go:146, so the new reason needs no other plumbing.
• The regression test serves a pull_request object on /repos/o/r/issues/14730 and fails any non-GET, so it would fail without the guard.

PR body matches the diff. Nothing further from me.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

[hivecommons-hive]

Evidence bundle `#14745c61d45d` sha256:74b3a1cc7cf6485bca02d183244390eb82814d69bb7d62d07ea1d710a481f040 — download from the dashboard or `hivectl review evidence #14745`.

[github-actions]

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback