Skip to content

📖 docs: re-point scale-envelope RankActionableIssues citation after client.go shift - #14846

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-scale-envelope-citation
Oct 28, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-scale-envelope-citation

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Why

The required relative links and anchors resolve check has been red on v5 since d98b765 (and on every PR rebased past it, e.g. #14818): src/docs/scale-envelope.md:37 cites src/pkg/github/client.go:4679-4696 for RankActionableIssues / AgeMinutes, but that range no longer contains either anchor after surrounding code in client.go moved. The checker reports:

DRIFT src/docs/scale-envelope.md:37 src/pkg/github/client.go:4679-4696 -> src/pkg/github/client.go lacks anchor(s) near cited range: AgeMinutes

This re-points the citation to the function's current location (4704-4714). Docs-only; no behaviour change, so no changelog fragment.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…lient.go shift

The 'relative links and anchors resolve' gate has been red on v5 since
d98b765: scale-envelope.md:37 cited client.go:4679-4696, which no longer
contains RankActionableIssues or AgeMinutes after the surrounding code moved.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 28, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 28, 2026
@github-actions

github-actions Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

No conflicting open PRs or same-file overlaps were found.

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against v5: RankActionableIssues now starts at src/pkg/github/client.go:4704 and the AgeMinutes comparison the sentence cites is at :4713, so the new 4704-4714 range contains both anchors the checker looks for. The old 4679-4696 range no longer does. One-line citation fix, nothing else changed. Looks correct to me — and since the relative links and anchors resolve check has been red on v5 for every PR rebased past d98b765, this is worth landing ahead of the queue.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 6cfafe3 into v5 Oct 28, 2026
80 of 84 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-scale-envelope-citation branch October 28, 2026 05:27
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#14846459299b` sha256:3c08c0e3c1d8e1404ec32672cc791f64dd54080c89ab2683196490730a479db8 — download from the dashboard or `hivectl review evidence #14846`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants