Repository navigation
π docs: refresh operator decision API reference - #15247
Conversation
Document all accepted decision values and replace the stale never-merges claim with immediate and queued merge semantics, permissions, and self-merge restrictions. Hive-Run: #15183 Hive-Plan: docs-currency-decision-row Hive-Spec: #15183#decision-api-currency Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
hive/awaiting-ci: merged v5 into the branch (api-reference citation conflict resolved; citation check passes). CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read the handler this row documents (src/pkg/dashboard/api_repo_item_decision.go on v5) against the refreshed row. Everything the new text adds checks out: adopt/re-author/merge-now/queue-merge are the handler's constants (lines 64β77), the merger or owner access required bar is repoItemMergeDecisionAllowed (line ~452/466), and status: "merged" / "queued-for-merge" are the literal response strings (lines 515, 536). The pkg/dashboard/api.go:338 citation still points at the /decision route registration, so the api-reference citation check should stay green.
One gap, since the point of this PR is to make the row current: the handler on v5 also accepts reroute (constant and case repoItemDecisionReroute at line ~408, request field to at line ~115, error text at line ~459: want approve, direction, close-superseded, close-wontfix, adopt, reroute, re-author, merge-now or queue-merge). It landed in #15085, which is already below this branch's merge-base, and api-reference.md on v5 mentions it zero times. The same struct also carries force (Adopt-now bypass, line ~111β114). Suggest the row's Body list and the sentence on adopt/re-author pick those up in the same push β low severity, docs only, no code concern.
Looks correct to me otherwise; CI is still pending on the rebased head.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
The operator decision row omitted the reroute decision and the force (adopt now) and to (reroute target) body fields that api_repo_item_decision.go already accepts on v5. Hive-Fix-Attempt: 1/6 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Read the handler rather than the diff: every decision kind, body field and status this row now documents matches src/pkg/dashboard/api_repo_item_decision.go β the accepted list at :457 (approve, direction, close-superseded, close-wontfix, adopt, reroute, re-author, merge-now, queue-merge), force/to at :114/:413, already-adopted/rerouted/merged/queued-for-merge statuses (:515, :536), the 409s for adoption disabled (:420), closed/merged (:483β:487) and non-hive direction (:614). The route citation pkg/dashboard/api.go:338 is the real registration.
The conflicts-with-open-pr label looks stale for this head: git merge-tree of 8464bac onto v5 4db33fe is clean. Looks correct to me.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
Thank you for your contribution! Your PR has been merged. We'd love to hear how your experience was: share feedback |
Supersedes #15184 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).
Fixes #15183
This branch is #15184's head
150888b66673as pushed by @thatguywob (forkthatguywob/hive), unchanged. Last lane reason on the original:label:needs-rebase.Hive fix agent: rebase this branch on
v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and theirSigned-off-by; add your own sign-off on your commits. Do not open another PR.