Skip to content

πŸ“– docs: refresh operator decision API reference - #15247

Merged
hivecommons-hive[bot] merged 3 commits into
v5from
hive/adopt-15184
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 3 commits into
v5from
hive/adopt-15184

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersedes #15184 (adopted after CI went red and the contributor was unavailable; original commits by @thatguywob preserved).

Fixes #15183

This branch is #15184's head 150888b66673 as pushed by @thatguywob (fork thatguywob/hive), unchanged. Last lane reason on the original: label:needs-rebase.

Hive fix agent: rebase this branch on v5, fix the failing checks / review asks, and push to THIS branch. Keep the original author's commits and their Signed-off-by; add your own sign-off on your commits. Do not open another PR.

Document all accepted decision values and replace the stale never-merges claim with immediate and queued merge semantics, permissions, and self-merge restrictions.

Hive-Run: #15183
Hive-Plan: docs-currency-decision-row
Hive-Spec: #15183#decision-api-currency
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign hanthor for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) labels Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15256 πŸ› clanker PRs with a human changes-requested review show Returned to contributor, not Sentinel alert CONFLICT src/docs/api-reference.md
#15251 πŸ› tracker: show Merging in the merge gate for at least the toast lifetime before βœ“ same files src/docs/api-reference.md
#15122 πŸ› Write-back containment: per-kind gate for every unsolicited GitHub write, with backfill guard same files src/docs/api-reference.md
#15104 πŸ› Activity Monitor: Rebase, then merge as maintainer; fixer owns parked conflicting PRs; dismiss self-inflicted changes_requested same files src/docs/api-reference.md
#15186 πŸ› Activity Monitor: one coherent post-decision state for Let hive decide rows; 060 reviewed in CI / Review same files src/docs/api-reference.md
#15134 πŸ› Delegated decision on a capability gap: model the blocker, stop the un-park/re-park loop, name the missing App permission same files src/docs/api-reference.md

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: merged v5 into the branch (api-reference citation conflict resolved; citation check passes). CI pending β€” sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: b3591ae

β€” hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@kubestellar-prow kubestellar-prow Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the handler this row documents (src/pkg/dashboard/api_repo_item_decision.go on v5) against the refreshed row. Everything the new text adds checks out: adopt/re-author/merge-now/queue-merge are the handler's constants (lines 64–77), the merger or owner access required bar is repoItemMergeDecisionAllowed (line ~452/466), and status: "merged" / "queued-for-merge" are the literal response strings (lines 515, 536). The pkg/dashboard/api.go:338 citation still points at the /decision route registration, so the api-reference citation check should stay green.

One gap, since the point of this PR is to make the row current: the handler on v5 also accepts reroute (constant and case repoItemDecisionReroute at line ~408, request field to at line ~115, error text at line ~459: want approve, direction, close-superseded, close-wontfix, adopt, reroute, re-author, merge-now or queue-merge). It landed in #15085, which is already below this branch's merge-base, and api-reference.md on v5 mentions it zero times. The same struct also carries force (Adopt-now bypass, line ~111–114). Suggest the row's Body list and the sentence on adopt/re-author pick those up in the same push β€” low severity, docs only, no code concern.

Looks correct to me otherwise; CI is still pending on the rebased head.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

The operator decision row omitted the reroute decision and the force
(adopt now) and to (reroute target) body fields that
api_repo_item_decision.go already accepts on v5.

Hive-Fix-Attempt: 1/6
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: ci-maintainer <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@hivecommons-hive hivecommons-hive Bot added stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head stage/070-fixing Hive-authored PR: CI red, changes requested or needs rebase; a hive agent is fixing it labels Oct 29, 2026
@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the handler rather than the diff: every decision kind, body field and status this row now documents matches src/pkg/dashboard/api_repo_item_decision.go β€” the accepted list at :457 (approve, direction, close-superseded, close-wontfix, adopt, reroute, re-author, merge-now, queue-merge), force/to at :114/:413, already-adopted/rerouted/merged/queued-for-merge statuses (:515, :536), the 409s for adoption disabled (:420), closed/merged (:483–:487) and non-hive direction (:614). The route citation pkg/dashboard/api.go:338 is the real registration.

The conflicts-with-open-pr label looks stale for this head: git merge-tree of 8464bac onto v5 4db33fe is clean. Looks correct to me.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive
hivecommons-hive Bot merged commit d363e5b into v5 Oct 29, 2026
76 of 82 checks passed
@kubestellar-prow
kubestellar-prow Bot deleted the hive/adopt-15184 branch October 29, 2026 03:00
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#152478464bac` sha256:14ffbf2bfcc64df6618cf3ad679cf18a0a65911993db4da0f9cd294ca24419cd β€” download from the dashboard or `hivectl review evidence #15247`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/060-reviewed Review swarm verdict approve; a gate is still pending (CI running, soak not started) labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR conflicts-with-open-pr Open PR has a merge conflict with another open PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (docs-currency): api-reference.md decision row still says 'Never merges' and lists only four decisions (stale since #15087)

1 participant