Skip to content

🐛 fix(automerge): key the supersede base-merge claim by prior_copy - #15260

Merged
hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15225
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
v5from
scanner/fix-15225

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

replaySupersedeOntoBase's branch_push claim carried no prior_copy, unlike the push/create claims keyed in #15209. On re-adoption after a closed copy, the mutation journal treated it as already applied, so the base was never merged into hive/adopt-N and the fresh copy could open with the conflict. The claim is now keyed by the prior copy through a shared helper, and a test covers the re-adoption.

Closes #15225

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

…-adoption replays the base merge

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15240 🐛 Never adopt a person's PR: owner/human-authored PRs return to their author instead of the contributor-offline lane same files src/pkg/github/automerge/automerge_contributor_adopt.go
#15219 🐛 fix: preserve human and owner PRs during delegated decisions same files src/pkg/github/automerge/automerge_contributor_adopt.go

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me; read the tree at v5, not just the diff.

  • Mechanism checks out: pkg/convergence/mutation/boundary.go:279 folds every claim.Inputs entry into the journaled effect's inputs (and therefore its logical ID). The two sibling claims in supersedeAdoptedPR (automerge_contributor_adopt.go:822 and :875) already carry prior_copy; the supersede-replay branch_push claim in replaySupersedeOntoBase was the only one that didn't, so a re-adoption with the same pr/head_sha/base collided with the first adoption's entry and the Repositories.Merge never ran. Adding prior_copy there is the minimal fix.
  • replaySupersedeOntoBase has exactly one caller (:863), and priorCopy is already in scope there, so the signature change is self-contained.
  • The new test asserts both the claim input (prior_copy == "90") and the observable effect (h.adopt.merges == ["hive/adopt-7<-v5"]), so it fails without the fix for the right reason.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 6ff73cd into v5 Oct 29, 2026
79 of 83 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#15260957ace9` sha256:64e041cccf8d6f00472383d329301c8de736a28a93ecb9c8e17621d0dabe2cc3 — download from the dashboard or `hivectl review evidence #15260`.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-15225 branch October 29, 2026 03:02
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR copilot dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Review backlog (correctness): replaySupersedeOntoBase claim is not keyed by prior_copy and is journal-replayed on re-adoption

0 participants