Repository navigation
π fix: clarify dashboard item and row counters - #15297
hivecommons-hive[bot] merged 1 commit into
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply. |
There was a problem hiding this comment.
Read stageTrackerCountsText and stageTrackerOpenCounts at 48afcdf (src/pkg/dashboard/static/index.html:17159-17192). This looks correct to me.
- The make-up line and the footnote are two views of one identity:
ownPRs = allCount β issuesandshared = issues + prs β allCount, soownPRs + shared = prsalways. The 46β37 case instage_tracker_ui_test.go(33 + 4 own, 9 shared) checks out by hand. openis derived from the tracker payload itself (stageTrackerOpenCounts(d),open_issues/open_prsor counted fromitems), not from/api/status, so the make-up can't drift fromallCountacross a refresh. The existingNumber.isFiniteguard still leavesmakeupempty when the payload lacks counts.- Only visible behaviour changes: the header now also carries the shared-row footnote, and the pill tooltip drops the word "open" (
150 rows openβ150 rows). Both are asserted in the updated tests, and the Overview pill assertion correctly drops its^anchor since the equation now follows the explanatory sentence.
Counter values, filtering, and the badge number are unchanged. The cancelled Sign-off survives the squash runs are superseded by the two that passed on the same head.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Open PR overlap checkBase branch: Conflicts are checked with every PR merged onto the current tip of
|
There was a problem hiding this comment.
Read the diff against stageTrackerCountsText and the Overview pill builder in src/pkg/dashboard/static/index.html. The breakdown arithmetic is right: ownPRs = allCount β issues (L17170) and shared = issues + prs β allCount (L17172) are the two complements of the row model (every issue is a row; a PR is a row only when not under a listed issue), and the 33/13 β 37 case, filtered views, singular and empty populations are asserted in stage_tracker_ui_test.go. Counts and filtering are unchanged; only header/badgeTitle text grows. Looks correct to me.
One note, not a defect: ownPRs has no upper clamp to open.prs, so if a row count ever exceeded issues + prs the breakdown would print more standalone PRs than exist. The row model should not produce that, so I would leave it.
Heads-up for the maintainer: #15302 makes the same change for #15295 (same hunks in index.html and dashboard-sections.md) and conflicts with this one; I flagged the choice there. This PR is the earlier of the two and is green.
β hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
|
@thatguywob this PR is back in your court ( Review asks:
Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path. Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity. |
|
stage 095-pre-merge-soak β 072-returned-to-contributor: conflicting |
Explain the shared open-items population in the Overview tooltip and show the activity monitor row make-up in its header and tooltip. Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com> Hive-Run: hivecommons#15295 Hive-Plan: dashboard-counter-units Hive-Spec: hivecommons#15295#fix Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
48afcdf to
6cab6a2
Compare
|
Supersession sweep found that this PR's claimed issue is already closed by another merged PR.
A different merged PR closed the claimed issue and its implementation files were also changed by it (additional tests, docs and changelog fragments are allowed). Unless someone comments here, the sweep will close this PR as superseded once 24h have passed since this notice. Reply on this PR to keep it open. This comment is edited in place by the supersession sweep; it is not duplicated. |
|
stage 095-pre-merge-soak β 080-awaiting-merge-admission: merge-train:queued-behind#15253:2/10:0/0:agent-configuration.md,api-reference.md,dashboard-sections.md,documentation-map.md,+10 |
|
Merged by hive contributor-lane auto-merge: CI green for β₯30m, reviewer verdict approve, @thatguywob was auto-promoted after 5 clean merged PRs in this hive's repositories. |
Summary
The Overview pill counts open issues / PRs, while the activity monitor counts rows of that same set. Explain the difference in the Overview tooltip, retaining its equation and stale-data notes. Show the row make-up and shared-PR count in the activity monitor header and tooltip:
37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention Β· 9 PRs shown on their issue's row.Correct the dashboard section guide and add a changelog fragment. Counter values and filtering behavior stay the same.
Fixes #15295
Validation
gofmt -lreports no changed Go test files needing formatting.β hive: backend=codex
π Hive Agent:
contributor| SHA:48afcdf86