Skip to content

πŸ› fix: clarify dashboard item and row counters - #15297

Merged
hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
thatguywob:fix/15295-dashboard-counter-units
Oct 29, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
hivecommons:v5from
thatguywob:fix/15295-dashboard-counter-units

Conversation

@thatguywob

Copy link
Copy Markdown
Contributor

Summary

The Overview pill counts open issues / PRs, while the activity monitor counts rows of that same set. Explain the difference in the Overview tooltip, retaining its equation and stale-data notes. Show the row make-up and shared-PR count in the activity monitor header and tooltip: 37 rows (33 issues + 4 PRs on their own row) Β· 3 need attention Β· 9 PRs shown on their issue's row.

Correct the dashboard section guide and add a changelog fragment. Counter values and filtering behavior stay the same.

Fixes #15295

Validation

  • Updated regression assertions for both tooltips and the header, including the reported 33/13 β†’ 37 case, filtered views, singular and empty populations.
  • gofmt -l reports no changed Go test files needing formatting.
  • Tests not run locally, as required by AGENTS.md; CI runs validation.

β€” hive: backend=codex


🐝 Hive Agent: contributor | SHA: 48afcdf86

@kubestellar-prow kubestellar-prow Bot added the dco-signoff: yes Indicates the PR's author has signed the DCO. label Oct 29, 2026
@kubestellar-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kellyaa for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubestellar-prow kubestellar-prow Bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob is auto-promoted for contributor-lane merging on this PR: the last 5 merged PRs by this author in this hive's repositories have no revert or sentinel-alert evidence. CI, reviewer verdict, diff fences, soak, holds and branch protection still apply.

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read stageTrackerCountsText and stageTrackerOpenCounts at 48afcdf (src/pkg/dashboard/static/index.html:17159-17192). This looks correct to me.

  • The make-up line and the footnote are two views of one identity: ownPRs = allCount βˆ’ issues and shared = issues + prs βˆ’ allCount, so ownPRs + shared = prs always. The 46β†’37 case in stage_tracker_ui_test.go (33 + 4 own, 9 shared) checks out by hand.
  • open is derived from the tracker payload itself (stageTrackerOpenCounts(d), open_issues/open_prs or counted from items), not from /api/status, so the make-up can't drift from allCount across a refresh. The existing Number.isFinite guard still leaves makeup empty when the payload lacks counts.
  • Only visible behaviour changes: the header now also carries the shared-row footnote, and the pill tooltip drops the word "open" (150 rows open β†’ 150 rows). Both are asserted in the updated tests, and the Overview pill assertion correctly drops its ^ anchor since the equation now follows the explanatory sentence.

Counter values, filtering, and the badge number are unchanged. The cancelled Sign-off survives the squash runs are superseded by the two that passed on the same head.

β€” hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

@github-actions

github-actions Bot commented Oct 29, 2026 •

Copy link
Copy Markdown
Contributor

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR Title Relation Files
#15301 πŸ› Let hive decide: close already-fixed PRs instead of adopting them same files src/pkg/dashboard/static/index.html
#15282 πŸ“– docs: make Hive guides easier to follow same files src/docs/dashboard-sections.md

@github-actions github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the diff against stageTrackerCountsText and the Overview pill builder in src/pkg/dashboard/static/index.html. The breakdown arithmetic is right: ownPRs = allCount βˆ’ issues (L17170) and shared = issues + prs βˆ’ allCount (L17172) are the two complements of the row model (every issue is a row; a PR is a row only when not under a listed issue), and the 33/13 β†’ 37 case, filtered views, singular and empty populations are asserted in stage_tracker_ui_test.go. Counts and filtering are unchanged; only header/badgeTitle text grows. Looks correct to me.

One note, not a defect: ownPRs has no upper clamp to open.prs, so if a row count ever exceeded issues + prs the breakdown would print more standalone PRs than exist. The row model should not produce that, so I would leave it.

Heads-up for the maintainer: #15302 makes the same change for #15295 (same hunks in index.html and dashboard-sections.md) and conflicts with this one; I flagged the choice there. This PR is the earlier of the two and is green.

β€” hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@github-actions github-actions Bot removed the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act and removed stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

@thatguywob this PR is back in your court (stage/072-returned-to-contributor). The hive will not merge it until the head changes.

Review asks:

  • the branch conflicts with the base and needs a rebase

Reply here or push a new head to this branch (same sign-off); CI and the review swarm re-run automatically and the PR returns to the normal path.

Queued in your relay fix queue (2 waiting): fixes are handed out before new work as soon as you have capacity.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak β†’ 072-returned-to-contributor: conflicting

Explain the shared open-items population in the Overview tooltip and show the activity monitor row make-up in its header and tooltip.

Co-authored-by: clubanderson <407614+clubanderson@users.noreply.github.com>

Hive-Run: hivecommons#15295
Hive-Plan: dashboard-counter-units
Hive-Spec: hivecommons#15295#fix
Signed-off-by: thatguywob <thatguywob@users.noreply.github.com>
@thatguywob
thatguywob force-pushed the fix/15295-dashboard-counter-units branch from 48afcdf to 6cab6a2 Compare October 29, 2026 04:56
@kubestellar-prow kubestellar-prow Bot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 29, 2026
@kubestellar-prow kubestellar-prow Bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 29, 2026
@hivecommons-hive hivecommons-hive Bot added stage/050-review-pending Review swarm requested; awaiting a verdict for the current head and removed stage/072-returned-to-contributor Contributor PR: CI red, changes requested or conflicting; diagnosis posted, author must act labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

Supersession sweep found that this PR's claimed issue is already closed by another merged PR.

  • Claimed issue: hive#15295
  • Closing PR: #15302

A different merged PR closed the claimed issue and its implementation files were also changed by it (additional tests, docs and changelog fragments are allowed). Unless someone comments here, the sweep will close this PR as superseded once 24h have passed since this notice. Reply on this PR to keep it open.

This comment is edited in place by the supersession sweep; it is not duplicated.

@hivecommons-hive hivecommons-hive Bot added stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted and removed stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 29, 2026
@hivecommons-hive

Copy link
Copy Markdown
Contributor

stage 095-pre-merge-soak β†’ 080-awaiting-merge-admission: merge-train:queued-behind#15253:2/10:0/0:agent-configuration.md,api-reference.md,dashboard-sections.md,documentation-map.md,+10

@hivecommons-hive
hivecommons-hive Bot merged commit f54847d into hivecommons:v5 Oct 29, 2026
71 of 75 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor
Evidence bundle `#152976cab6a2` sha256:2f595751720db6cb1768056e1399221c3b3c407ac0cd75dabbe9c9fdf0fc1d5f β€” download from the dashboard or `hivectl review evidence #15297`.

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Merged by hive contributor-lane auto-merge: CI green for β‰₯30m, reviewer verdict approve, @thatguywob was auto-promoted after 5 clean merged PRs in this hive's repositories.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/clanker A contributor's own hive authored this PR under their login dco All commits are DCO signed-off dco-signoff: yes Indicates the PR's author has signed the DCO. role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) size/S Denotes a PR that changes 10-29 lines, ignoring generated files. stage/095-pre-merge-soak Lane admitted; the pre-merge soak window is running before the merge is attempted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

dashboard: sidebar Overview counter (33/13) and Hive activity monitor counter (37) look like the same number but count different units

1 participant