🐛 tracker: a PR waiting on its author never leads with Close as superseded by clubanderson · Pull Request #15664 · hivecommons/hive

clubanderson · 2026-10-30T03:48:11Z

Fixes #15663

Why

A human-authored PR the review swarm sent back (e.g. 🐛 dashboard: scroll-edge fade follows the theme in light mode #15626, 🐛 review: only a security finding parks an untrusted PR during CI/Review #15641) rendered the red Close as superseded inline button. stageTrackerLeadActions flagged every server decide:* option not already in the Decide… submenu as lead; with delegate/hold taken, the first leftover was the close.
An issue with several linked PRs whose one parked PR asks ([Tests] v5 test failure on 4536f90 #15320 → 🐛 fix(dashboard): pass PR-open predicate to stageTrackerResolveLinkedPRs calls #15647, Review backlog (correctness): README still lists hosted/self-hosted run routes twice #15338 → 📖 docs: remove duplicate README run routes #15648) rendered the same Let hive decide button on the parent header and on the nested PR sub-row.

What

StageTrackerDecisionOption gains Lead bool (json:"lead"); the server sets it only in decisionLeadWithCloseSuperseded (the reviewer's RedundantOf), the one place a close is the answer.
stageTrackerLeadActions never flags a danger (decide:close-*) option as the row's lead unless o.lead; the Decide… fallback in stageTrackerLeadAction skips danger entries. The ⋯ menu is unchanged.
decisionForWaitingOnAuthor no longer asks "Wait for them, or close it?"; the waiting pill for a person's own PR reads "waiting on @author to push".
New stageTrackerLeadActionOnRow: an issue row whose lead acts on a nested PR drawn as a sub-row renders no button — the sub-row (with the chevron) carries it; the parent keeps "Decide PR #N…" in ⋯.
static/index.html regenerated with make dashboard-gen.

Tests

stage_tracker_row_actions_test.go: waiting-on-author → no close lead / no inline button; the live 085 sent-back shape → non-destructive lead, close still in ⋯; lead: true redundant-of → Close as superseded still leads.
stage_tracker_decision_redundant_test.go: Lead set on the RedundantOf path only; TestDecisionForWaitingOnAuthorNeverLeadsWithClose.
stage_tracker_lead_action_test.go: a parent + nested-PR pair yields exactly one lead button.
Presence tests updated for "to push".

@x

…seded A human-authored PR the review swarm sent back for changes rendered the red inline 'Close as superseded' button: stageTrackerLeadActions flagged every server decide:* option not already in the Decide… submenu as lead, and once delegate/hold were taken the first leftover was the close. - StageTrackerDecisionOption gains Lead (json lead); the server sets it only where a close is the answer (decisionLeadWithCloseSuperseded, the reviewer's RedundantOf). - The SPA never leads a row with a danger option unless o.lead, and the Decide… fallback skips danger entries; the ⋯ menu is unchanged. - The waiting pill for a person's own PR reads 'waiting on @x to push' and the popover question no longer asks 'or close it?'. - Tests updated; focused cases for waiting-on-author (no close lead), the live 085 sent-back shape, and redundant-of (close still leads). Signed-off-by: Andrew Anderson <andy@clubanderson.com>

…sted PR An issue with several linked PRs draws a sub-row per PR; when one parked PR asks, stageTrackerDecisionTarget resolved the issue row's lead to that PR as well, so the same 'Let hive decide' button appeared on the parent header and on the sub-row (hive#15320 → #15647, hive#15338 → #15648). stageTrackerLeadActionOnRow drops the parent's lead when it acts on a nested PR that is drawn as a sub-row and renders its own; the parent's ⋯ menu keeps 'Decide PR #N…'. Test: a parent + nested-PR pair yields one button. Signed-off-by: Andrew Anderson <andy@clubanderson.com>

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

kubestellar-prow · 2026-10-30T03:48:15Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nicholasjackson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

github-actions · 2026-10-30T03:48:55Z

Open PR overlap check

Base branch: v5

Conflicts are checked with every PR merged onto the current tip of v5, so a PR that only needs a rebase is not reported as conflicting with its siblings.

PR	Title	Relation	Files
#15637	📖 community: list the Twitch live stream everywhere community links live	same files	`src/pkg/dashboard/static/index.html`
#15657	🐛 Tracker: chevron column follows the current state, never the highest stage reached	same files	`src/pkg/dashboard/static-src/js/tracker-row.js` `src/pkg/dashboard/static/index.html`
#15669	✨ Stream the tracker's sounds on the Activity Monitor Twitch stream	same files	`src/pkg/dashboard/static/index.html`
#15662	🐛 Adopt stuck contributor PRs automatically from the tracker's offer predicate	same files	`src/pkg/dashboard/stage_tracker_presence_test.go`
#15566	🌱 refactor: split stage tracker UI tests	same files	`src/pkg/dashboard/static/index.html`
#15530	🐛 fix(dashboard): issue-row linked PR passes null when the lineage chip is empty	same files	`src/pkg/dashboard/static-src/js/tracker-row.js` `src/pkg/dashboard/static/index.html`
#15633	🌱 refactor: split stage tracker UI tests	same files	`src/pkg/dashboard/static/index.html`
#15680	🐛 review: one backlog issue per finding; carried-over notes never refile	same files	`src/pkg/dashboard/static/index.html`
#15658	🐛 fix(tracker): PRs at CI / Review ride no merge train; overlap hint instead	same files	`src/pkg/dashboard/static-src/js/tracker-row.js` `src/pkg/dashboard/static/index.html`
#15668	🐛 Lead 090 merge-gate action is Approve and let hive merge	same files	`src/pkg/dashboard/stage_tracker_decision.go` `src/pkg/dashboard/stage_tracker_row_actions_test.go` `src/pkg/dashboard/static-src/js/tracker-actions.js` `src/pkg/dashboard/static-src/js/tracker-row.js` `src/pkg/dashboard/static/index.html`
#15521	🌱 refactor: split tracker row source	CONFLICT	`src/pkg/dashboard/static-src/js/tracker-row.js`

hivecommons-hive · 2026-10-30T04:01:57Z

@clubanderson this PR is held at stage/071-needs-author and the hive will not merge it yet.

Failing checks:

coverage

Next: the hive does not push to your branch. Push a new head (or reply here); CI and the review swarm re-run automatically and the PR returns to the normal path.

hivecommons-hive · 2026-10-30T04:01:58Z

stage 080-awaiting-merge-admission → 071-needs-author: required-check-failing:coverage

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

…ubmenu lists its verb Signed-off-by: Andrew Anderson <andy@clubanderson.com>

hivecommons-hive · 2026-10-30T04:25:05Z

stage 080-awaiting-merge-admission → 050-review-pending: required-check-pending:Sign-off survives the squash

hivecommons-hive

Read tracker-actions.js:355-470, tracker-row.js:1043-1350, stage_tracker_decision.go:555-900 and the generated index.html at c8bc8fa. Looks correct to me.

The lead rule is now explicit in one place: lead: !danger || !!o.lead (tracker-actions.js:373) plus the submenu fallback filtering !x.danger (:445). The only producer of Lead: true is decisionLeadWithCloseSuperseded (stage_tracker_decision.go:894), i.e. RedundantOf set, so a close can lead only when a reviewer named the superseding PR. The Go test asserts no other option is ever marked lead.
I checked the taken && … && !o.lead bypass (:364): in the redundant-of case the ⋯ menu gets the prefilled "Close as superseded" at top level while Decide… keeps the generic "Close as superseded by…" (stageTrackerDecideOptions). The inline comment says that's intended; noting it so nobody reads it as a dup later.
stageTrackerLeadActionOnRow (:472-481) only suppresses the parent button when item.kind === 'issue', sub-rows are actually drawn (subRows is set only on the linked.length > 1 branch, tracker-row.js:1304), the target is one of them, and that sub-row itself yields a lead — so the single-linked-PR case and an issue's own 045 ask keep their button. Both pinned in the node fixture.
static/index.html is regenerated in the diff and matches static-src for the three touched functions.

— hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88

github-actions · 2026-10-30T04:41:25Z

Thank you for your contribution! Your PR has been merged.

We'd love to hear how your experience was: share feedback

Port the v5 tracker-row.js changes (hivecommons#15657, hivecommons#15664, hivecommons#15668, hivecommons#15680) into the split files: stageTrackerAnchor under-repair column (tracker-row.js), acted labels (tracker-row-strip.js), queue-merge pending copy (tracker-row-acted.js), and stageTrackerLead / left_train / subRows / review notes (tracker-row-layout.js). static/index.html regenerated and matches the auto-merge byte for byte. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>

clubanderson added 3 commits October 29, 2026 23:42

📖 changelog: cover the duplicate Let hive decide fix

4f4a8cd

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

kubestellar-prow Bot added dco-signoff: yes Indicates the PR's author has signed the DCO. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 30, 2026

github-actions Bot added the conflicts-with-open-pr Open PR has a merge conflict with another open PR label Oct 30, 2026

🌱 test: the sent-back 085 row keeps its close inside the Decide… submenu

b7a17c5

Signed-off-by: Andrew Anderson <andy@clubanderson.com>

hivecommons-hive Bot mentioned this pull request Oct 30, 2026

refactor: src/pkg/dashboard/stage_tracker_decision.go is a merge hotspot — split into 4 units #15676

Closed

🐛 tracker: a server-marked lead heads the row even when the Decide… s…

c8bc8fa

…ubmenu lists its verb Signed-off-by: Andrew Anderson <andy@clubanderson.com>

hivecommons-hive Bot reviewed Oct 30, 2026

View reviewed changes

This was referenced Oct 30, 2026

🐛 review: one backlog issue per finding; carried-over notes never refile #15680

Merged

🐛 review: split the grounding budget across fan-out sub-agents #15617

Merged

clubanderson merged commit d086be1 into v5 Oct 30, 2026
77 checks passed

kubestellar-prow Bot deleted the fix/no-destructive-lead-chip branch October 30, 2026 04:41

Navigation Menu

Repository navigation

🐛 tracker: a PR waiting on its author never leads with Close as superseded - #15664

🐛 tracker: a PR waiting on its author never leads with Close as superseded#15664
clubanderson merged 5 commits into
v5from
fix/no-destructive-lead-chip

clubanderson commented Oct 30, 2026

Uh oh!

kubestellar-prow Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 •

edited

Loading

Uh oh!

hivecommons-hive Bot commented Oct 30, 2026

Uh oh!

hivecommons-hive Bot commented Oct 30, 2026

Uh oh!

hivecommons-hive Bot commented Oct 30, 2026

Uh oh!

hivecommons-hive Bot left a comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

clubanderson commented Oct 30, 2026

Uh oh!

kubestellar-prow Bot commented Oct 30, 2026

Uh oh!

github-actions Bot commented Oct 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Open PR overlap check

Uh oh!

hivecommons-hive Bot commented Oct 30, 2026

Uh oh!

hivecommons-hive Bot commented Oct 30, 2026

Uh oh!

hivecommons-hive Bot commented Oct 30, 2026

Uh oh!

hivecommons-hive Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Oct 30, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

github-actions Bot commented Oct 30, 2026 •

edited

Loading