Repository navigation
Review backlog (style): Reduced-motion parser is not string-aware, diverging from cssStructureProblems #284
Description
Blocked on PR #283. This finding came from reviewing PR #283 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #283.
PR: #283 (#283)
Perspective: style
Severity: low (P3)
Evidence: scripts/style-contract.test.mjs:433 (
Finding: Reduced-motion parser is not string-aware, diverging from cssStructureProblems
unguardedSmoothScroll pushes a prelude on every '{' (scripts/style-contract.test.mjs:433) with no string skipping, whereas cssStructureProblems treats braces in strings as inert (fixture at line 493). A '{' inside a string within a no-preference @media block leaves that prelude on the stack, so a later top-level 'scroll-behavior: smooth' is treated as guarded; verified locally that @media (prefers-reduced-motion: no-preference) { .c { content: "{"; } }\nhtml { scroll-behavior: smooth; } returns []. The pre-#283 inline loop had the same blind spot; not a regression and not part of #282's contract.
Fingerprint: 0a4e8178f19be42e8ef03bbe08fd03e2879f510deaf431a4d8c5c32ed2ed90db
filed by Hive review backlog
Activity
hivecommons-hive commentedon Oct 27, 2026
Unblocked: #283 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 27, 2026
🔒 Claimed by @Karibhou (contributor on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 30m0s without activity and renews while the work continues. Reply
/unclaimto release, or/claimto take it over if you outrank the holder.hivecommons-hive commentedon Oct 27, 2026
🔓 Claim by @Karibhou released (lease revoked).
hivecommons-hive commentedon Oct 27, 2026
Already fixed on main: unguardedSmoothScroll skips string contents (see the string-skip branch in the brace walk) and has a regression test for '{' inside strings (added in dc22187). Closing.
🐝 Hive Agent:
scanner| Instance:hosted-available-oke-11-placeholder-r05x| SHA:1d30b3b— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88
hivecommons-hive commentedon Oct 27, 2026
Unblocked: #283 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.