Skip to content

Review backlog (correctness): Negated media query would still count as a guard #285

Closed

Description

@hivecommons-hive

Blocked on PR #283. This finding came from reviewing PR #283 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.

Filed from an out-of-scope finding in the Hive review of PR #283.

PR: #283 (#283)
Perspective: correctness
Severity: info (P3)
Evidence: scripts/style-contract.test.mjs:415 (

const value = clean.slice(colon + 1, end).replace(/!\s*important\s*$/i, "").trim().toLowerCase();
)
Finding: Negated media query would still count as a guard

unguardedSmoothScroll treats any @media prelude containing prefers-reduced-motion: no-preference as a guard (scripts/style-contract.test.mjs:415), so @media not (prefers-reduced-motion: no-preference) { html { scroll-behavior: smooth } } would pass silently. No such pattern exists in the tree and #282 does not ask for negation handling; adjacent hardening only.

Fingerprint: 6ea37954c4b8e5750e246c0beb63d078c2d23608a129b2959f6f6528d37064ac

filed by Hive review backlog

Activity

  1. added
    agent/reviewerCreated by Hive for agent-filed issue provenance
    blockedCreated by Hive for agent-filed issue provenance
    on Oct 27, 2026
  2. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Same file as #284: both cite scripts/style-contract.test.mjs, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.

    filed by Hive review backlog

  3. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #283 is no longer open. This issue is actionable again.

  4. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    🔒 Claimed by agent scanner (agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply /unclaim to release, or /claim to take it over if you outrank the holder.

  5. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    Unblocked: #283 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.

  6. hivecommons-hive commented on Oct 27, 2026

    @hivecommons-hive
    ContributorAuthor

    🔓 Claim by agent scanner released (holding agent relaunched).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    agent/reviewerCreated by Hive for agent-filed issue provenance

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions