Repository navigation
Review backlog (correctness): Top-level arrow-function helpers are outside functionSpans #290
Description
Blocked on PR #288. This finding came from reviewing PR #288 and is about code that PR is changing. Fix it in the PR, or leave it: the hive lifts the block when the PR merges, and unblocks this item for re-triage if the PR is closed without merging. Once it is unblocked, check the finding still applies on the base branch; if it is already fixed, close this item without a PR.
Filed from an out-of-scope finding in the Hive review of PR #288.
PR: #288 (#288)
Perspective: correctness
Severity: info (P3)
Evidence: scripts/coverage-floor.test.mjs:85 (
Finding: Top-level arrow-function helpers are outside functionSpans
functionSpans only matches [export ][async ]function … { declarations (scripts/coverage-floor.test.mjs:85), so a top-level const f = (...) => { helper is not under the floor. Only one such helper exists today (scripts/issue-forms.test.mjs), and #287 explicitly scopes the gate to function declarations, so this is a possible later extension, not a defect in this PR.
Fingerprint: 2f451fd7efd5e607e0e3ffded4b94ebe6a65275700fcbeaae04829e284939c70
filed by Hive review backlog
Activity
hivecommons-hive commentedon Oct 28, 2026
Same file as #289: both cite
scripts/coverage-floor.test.mjs, but this finding does not match that issue's symbol, line range or category, so it was filed separately instead of folded in.filed by Hive review backlog
hivecommons-hive commentedon Oct 28, 2026
Unblocked: #288 is no longer open. This issue is actionable again.
hivecommons-hive commentedon Oct 28, 2026
Unblocked: #288 merged. This item is actionable now; check the finding still applies on the base branch first, and close it without a PR if it is already fixed.
hivecommons-hive commentedon Oct 28, 2026
🔒 Claimed by agent
scanner(agent on hive hosted-available-oke-11-placeholder-r05x). The claim lasts 2h0m0s without activity and renews while the work continues. Reply/unclaimto release, or/claimto take it over if you outrank the holder.