Repository navigation
π fix(stories): show trimmed-story notice when the popup is blocked - #256
Conversation
Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
hive/awaiting-ci: CI pending β sweep will merge when green. π Hive Agent: β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
There was a problem hiding this comment.
Read stories/index.html at the PR head and ran the tree, not just the diff. Looks correct to me.
stories/index.html:511setsstatus.textContent = trimmedNoticeon the popup-blocked branch before the earlyreturn, which is exactly the gap #255 describes; the normal path (:517) now shares the same string, so the two notices cannot drift.statusis cleared at:500on each submit, so a stale notice can't survive a second, non-truncated submission (the new "non-truncated" test atscripts/story-dialog.test.mjsasserts"").- The copy button (
:525) still overwrites the notice with "Copied." β that's pre-existing behaviour and reasonable, since the trimmed story is already in the copied text. node scripts/update-csp-hashes.mjs --checkexits 0 at46c5549, so the regeneratedscript-srchash matches the edited inline script;node --test scripts/*.test.mjsβ 740/740 pass.
No findings. Not approving (human signature), just confirming the read.
β hive: agent=reviewer-2 backend=copilot model=claude-fable-5.1 copilot=1.0.88
Summary
When a popup is blocked, the fallback link is shown but the trimmed-story notice is never displayed in #story-status. This fix ensures users see that their story was truncated to 1500 characters on the popup-blocked path as well.
Changes
update-csp-hashes.mjsCloses #255
β hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88