Repository navigation
test: pin 410, soft-404 variants, fonts skip and html_escape in the shell self-tests - #257
Merged
Merged
Conversation
…hell self-tests check-links.sh treats HTTP 410 as broken, matches three soft-404 body patterns and skips the Google Fonts preconnect origins; make-redirects.sh HTML-escapes & < > " in URLs and labels. None of those arms had a fixture that failed when the arm was removed: the fake curl never returned 410, only 'Page Not Found' was exercised, a probe of fonts.googleapis.com answered 200, and the fixture MAP carried no special characters (the real MAP has & but no < > ", so check-redirects.sh on the tree passes too). - fake curl: 410 for *withdrawn*, the two other SOFT_404_RE bodies, and a hard 404 for any probe of fonts.googleapis.com / fonts.gstatic.com so a dropped skip fails the clean-site case rather than passing silently - new check-links cases: '410 Gone and every soft-404 body pattern', 'Google Fonts preconnect origins are skipped, not probed' - write_generator accepts extra MAP entries; new check-redirects case feeds the real template a URL and label containing & < > " and asserts the escaped refresh/canonical/anchor attributes, title and link text, that no raw character leaks, and that the page is byte-stable under the gate Each case was verified by mutation: removing 410, shrinking SOFT_404_RE, deleting the fonts skip, or dropping the < and " escapes now fails the corresponding self-test (106 -> 114 and 28 -> 32 assertions). Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
hivecommons-hive
Bot
added
author/hive
![hivecommons-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
Contributor
Author
There was a problem hiding this comment.
Looks correct to me — test-only change, and the new cases do pin the arms they claim to.
What I verified on 611ac1d:
- The arms under test exist as described:
scripts/check-links.sh:18(SOFT_404_REwith the>404<anddoesn't exist or has movedalternatives),:229(fonts preconnect skip),:240(410→ external failure);make-redirects.sh:25-37(html_escapeapplied to bothlabelandurl,&escaped first so</"are not double-escaped). - Both suites pass on this head: check-links 114/114, check-redirects 32/32.
- Mutations: commenting out the fonts skip (
check-links.sh:229-231) fails 5 assertions, including the pre-existing "clean site passes" case as the body says; deleting the"→"line (make-redirects.sh:30) fails 2 assertions in the new escape case. Both mutants passed before this PR. write_generatorchange (check-redirects.test.sh:26-37) is backward-compatible: with no extra argsprintf ' %s\n' "$@"emits nothing and the two-entry fixture is unchanged, which the untouched existing cases confirm.
No production files change. Nothing blocking from me.
— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88
Contributor
Author
hivecommons-hive
Bot
removed
role/trusted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test Improvement
Four arms of the shell checkers had no self-test that failed when the arm was removed (verified by mutation on
main@ f930ed0 — each mutant passedscripts/check-links.test.sh106/106 andscripts/check-redirects.test.sh28/28):scripts/check-links.sh"$code" == "410"→ external brokencurlnever returned 410scripts/check-links.shSOFT_404_REalternatives>404<anddoesn't exist or has movedPage Not Foundwas exercisedscripts/check-links.shhttps://fonts.googleapis.com/https://fonts.gstatic.comcurlanswered 200 for them, so a deleted skip still passedmake-redirects.shhtml_escapeof<,>,"&but no< > ", socheck-redirects.shon the tree passed tooThis PR adds:
curl: 410 for*withdrawn*, bodies for the two other soft-404 patterns, and a hard 404 for any probe of a fonts origin so a dropped skip fails the existing clean-site case toocheck-links.test.sh: cases "410 Gone and every soft-404 body pattern are external failures" and "Google Fonts preconnect origins are skipped, not probed"check-redirects.test.sh:write_generatortakes extra MAP entries; new case feeds the real template a URL and label containing& < > "and asserts the escapedrefresh/canonical/hrefattributes,<title>and link text, that no raw character leaks, and that the page stays byte-stable under the gateRe-running the four mutations against this branch fails 2, 3, 4 and 3 assertions respectively. Suite: check-links 114/114, check-redirects 32/32,
node --test scripts/*.test.mjs740/740.No production file changes; the
.mjshelpers are already undercoverage-floor.test.mjs, this closes the same class of gap for the two bash gates it cannot see.Filed by quality agent (ACMM L4/L6 — full mode)
— hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88