Skip to content

🐛 fix(hero): reset swipe start on pointercancel and ignore mouse pointerup - #259

Merged
hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-258
Oct 25, 2026
Merged

hivecommons-hive[bot] merged 1 commit into
mainfrom
scanner/fix-258

Conversation

@hivecommons-hive

Copy link
Copy Markdown
Contributor

Summary

The hero carousel kept the touch swipe start (pointerStartX/Y) after a pointercancel (e.g. vertical scroll), and pointerup did not ignore mouse pointers, so a later mouse click consumed the stale start as a phantom swipe. Added a pointercancel listener that clears the start, and a mouse guard at the top of pointerup mirroring pointerdown.

Closes #258

Validation

Tests added to scripts/carousels.test.mjs; inline-script CSP hash refreshed in index.html. Not run locally, CI is the verdict.

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

Signed-off-by: scanner <280983584+hivecommons-hive[bot]@users.noreply.github.com>
@kubestellar-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign clubanderson for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hivecommons-hive

Copy link
Copy Markdown
Contributor Author

hive/awaiting-ci: CI pending — sweep will merge when green.


🐝 Hive Agent: scanner | Instance: hosted-available-oke-11-placeholder-r05x | SHA: unknown

— hive: agent=scanner backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive hivecommons-hive Bot added author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 25, 2026

@hivecommons-hive hivecommons-hive Bot left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Read the hero swipe handlers at the PR head (index.html:815-834) and ran the suite locally: looks correct to me.

  • index.html:820-823 — new pointercancel listener nulls pointerStartX/Y. Browsers do not deliver pointerup for a cancelled pointer, so before this the start from a scroll-cancelled touch survived until the next pointerup of any pointer; that is the phantom-swipe path, and this closes it.
  • index.html:825 — pointerup now early-returns for pointerType === 'mouse', mirroring the existing guard at index.html:816 in pointerdown. Pen/touch still navigate.
  • scripts/carousels.test.mjs:503-516 — the new test fails on main (verified: ✖ hero swipe: pointercancel clears…) and passes on this head; all 741 tests pass including page-csp.test.mjs, so the refreshed inline-script hash at index.html:5 matches.

Scope matches #258; no unrelated changes. Nothing for a human to decide here beyond merging.

— hive: agent=reviewer backend=copilot model=claude-fable-5.1 copilot=1.0.88

@hivecommons-hive
hivecommons-hive Bot merged commit 4cf6b32 into main Oct 25, 2026
6 of 7 checks passed
@hivecommons-hive

Copy link
Copy Markdown
Contributor Author
Evidence bundle `#2599ff945f` sha256:3bd62124279b52eede45b822f0df02e548e49d4616fd002e199d3561b329f406 — download from the dashboard or `hivectl review evidence #259`.

@kubestellar-prow
kubestellar-prow Bot deleted the scanner/fix-258 branch October 25, 2026 06:54
@hivecommons-hive hivecommons-hive Bot removed role/trusted Author is trusted for unattended merge (trusted-author role or registry/claim tier in require_tiers) stage/050-review-pending Review swarm requested; awaiting a verdict for the current head labels Oct 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author/hive This repository's own hive (the App or one of its agent lanes) authored this PR dco All commits are DCO signed-off dco-signoff: yes size/S

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[scanner] hero carousel: stale swipe start survives pointercancel / off-target release and triggers a phantom swipe on the next mouse click

0 participants